Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add tracing instrumentation for indexing paths #10962

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[Backport 2.x] Add tracing instrumentation for indexing paths #10962

merged 1 commit into from
Oct 27, 2023

Conversation

rayshrey
Copy link
Contributor

Description

Auto-backport for this PR failed.
Manually raising a PR to backport changes to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rayshrey
Add tracing instrumentation for indexing paths (opensearch-project#10273
8339e14 
)

* Add tracing instrumentation for indexing paths

Signed-off-by: Shreyansh Ray <[email protected]>

* Fix failing tests and review changes

Signed-off-by: Shreyansh Ray <[email protected]>

* Fix test failures due to Span not being properly closed

Signed-off-by: Shreyansh Ray <[email protected]>

* Changes to spans in primary and replica actions

Signed-off-by: Shreyansh Ray <[email protected]>

* Review comments fixes and refactoring

Signed-off-by: Shreyansh Ray <[email protected]>

* Precommit auto-changes

Signed-off-by: Shreyansh Ray <[email protected]>

* Add refresh policy as attribute

Signed-off-by: Shreyansh Ray <[email protected]>

* Fix changelog entry

Signed-off-by: Shreyansh Ray <[email protected]>

* Instrument primary/replica write in TransportWriteAction instead of TransportShardBulkAction

Signed-off-by: Shreyansh Ray <[email protected]>

* Modify SpanBuilder

Signed-off-by: Shreyansh Ray <[email protected]>

* spotlessApply and precommit

Signed-off-by: Shreyansh Ray <[email protected]>

* Change span names

Signed-off-by: Shreyansh Ray <[email protected]>

* Pass Noop Tracer instead of injected tracer

Signed-off-by: Shreyansh Ray <[email protected]>

* Reverting previous changes

Signed-off-by: Shreyansh Ray <[email protected]>

* Remove tracer variable from TransportShardBulkAction

Signed-off-by: Shreyansh Ray <[email protected]>

---------

Signed-off-by: Shreyansh Ray <[email protected]>
@reta reta added backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0 labels Oct 27, 2023
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 8339e14

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Oct 27, 2023

#5957
#10755
#10798

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Oct 27, 2023

#8771

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Oct 27, 2023

#10969

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Oct 27, 2023

#10231

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Oct 27, 2023 •
edited
Loading

#9499
#10902

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

@codecov
Copy link

codecov bot commented Oct 27, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@reta reta merged commit d179a0a into opensearch-project:2.x Oct 27, 2023
68 checks passed
@rayshrey rayshrey deleted the 2.x branch November 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayshrey @reta