Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to nodes/stats #10887

Merged

Conversation

ajaymovva
Copy link
Contributor

@ajaymovva ajaymovva commented Oct 24, 2023

Description

Added changes to integrate cpu AC to ResourceUsageCollector and Emit Stats

Related Issues

Ref: #8910

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ajaymovva ajaymovva changed the title Feature/admission control Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Compatibility status:

Checks if related components are compatible with change bcbd91e

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

❌ Gradle check result for 777cd03: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 07b4141: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testDefaultBufferInterval

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

✅ Gradle check result for a81b6d0: SUCCESS

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ajay Kumar Movva and others added 6 commits November 29, 2023 12:30
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Copy link
Contributor

❕ Gradle check result for bcbd91e: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.reindex.UpdateByQueryBasicTests.testMultipleSources

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Bukhtawar Bukhtawar merged commit 0b49929 into opensearch-project:main Nov 29, 2023
29 checks passed
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Jan 29, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Jan 31, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Jan 31, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 4, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 5, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 6, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 6, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
sachinpkale pushed a commit that referenced this pull request Feb 6, 2024
…ntroller (#12111)

* Added changes for AdmissionControl Interceptor and AdmissionControlService for RateLimiting (#9286)

* Changes for AdmissionControl Interceptor and AdmissionControlService for RateLimiting (#9286)

Signed-off-by: Ajay Kumar Movva <[email protected]>

* Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to nodes/stats (#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>

* Updating Version to 2.12 for the AC Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>

---------

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
Co-authored-by: Ajay Kumar Movva <[email protected]>
@ajaymovva ajaymovva deleted the feature/admission-control branch February 9, 2024 12:05
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <[email protected]>
Co-authored-by: Bharathwaj G <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants