-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Fix dissect ingest processor parsing empty brackets failed #10667
Conversation
Compatibility status:Checks if related components are compatible with change 6ccb649 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git] |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #10667 +/- ##
============================================
- Coverage 71.10% 71.05% -0.06%
+ Complexity 59204 59124 -80
============================================
Files 4869 4869
Lines 278732 278738 +6
Branches 40848 40849 +1
============================================
- Hits 198196 198049 -147
- Misses 63786 63989 +203
+ Partials 16750 16700 -50 ☔ View full report in Codecov by Sentry. |
Gradle Check (Jenkins) Run Completed with:
|
@dblock ,could you help to review this backport PR? |
@gaobinlong Please take a look at Gradle check failures, call out flakes and such. |
For some reason GH is not letting me restart the gradle check either, force push an update? |
@dblock I cannot update the backport branch because this PR was created by the bot, I don't have permission. |
I am not sure why, but GitHub UX no longer lets me restart this gradle check. Re-create the backport by hand please, sorry. |
* Fix dissect ingest processor parsing empty brackets failed Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Add assertion Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> (cherry picked from commit 7b62e2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5871d97
to
6ccb649
Compare
@gaobinlong I rebased this PR from |
❕ Gradle check result for 6ccb649: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Thanks @andrross , the failed test is flaky, and there's an issue. The check result becomes green, I think this PR can be merged now. |
This PR is stalled because it has been open for 30 days with no activity. |
Hi @gaobinlong, @dblock, and @andrross, the PR is stalled. Is this being worked upon? |
Backport 7b62e2f from #9255.