Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] - Add Telemetry metrics framework #10393

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Oct 5, 2023

Description

backport #10241 to 2.x

Related Issues

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gaganjuneja
Copy link
Contributor Author

@gbbafna Please take a look. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Compatibility status:

Checks if related components are compatible with change 381d153

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #10393 (381d153) into 2.x (fc7dc20) will increase coverage by 0.09%.
Report is 1 commits behind head on 2.x.
The diff coverage is 90.28%.

@@             Coverage Diff              @@
##                2.x   #10393      +/-   ##
============================================
+ Coverage     70.75%   70.85%   +0.09%     
- Complexity    58397    58445      +48     
============================================
  Files          4816     4826      +10     
  Lines        276031   276193     +162     
  Branches      40565    40569       +4     
============================================
+ Hits         195306   195695     +389     
+ Misses        64105    63779     -326     
- Partials      16620    16719      +99     
Files Coverage Δ
...arch/telemetry/metrics/DefaultMetricsRegistry.java 100.00% <100.00%> (ø)
...ch/telemetry/metrics/noop/NoopMetricsRegistry.java 100.00% <100.00%> (ø)
...va/org/opensearch/telemetry/metrics/tags/Tags.java 100.00% <100.00%> (ø)
.../org/opensearch/telemetry/OTelTelemetryPlugin.java 100.00% <100.00%> (ø)
...rg/opensearch/telemetry/OTelTelemetrySettings.java 100.00% <100.00%> (ø)
.../org/opensearch/telemetry/metrics/OTelCounter.java 100.00% <100.00%> (ø)
...search/telemetry/metrics/OTelMetricsTelemetry.java 100.00% <100.00%> (ø)
...pensearch/telemetry/metrics/OTelUpDownCounter.java 100.00% <100.00%> (ø)
...search/telemetry/tracing/OTelResourceProvider.java 100.00% <100.00%> (ø)
...search/telemetry/tracing/OTelTracingTelemetry.java 95.45% <100.00%> (+7.45%) ⬆️
... and 8 more

... and 496 files with indirect coverage changes

@gbbafna gbbafna merged commit 92a261b into opensearch-project:2.x Oct 5, 2023
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants