Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Telemetry metrics framework #10241
Add Telemetry metrics framework #10241
Changes from all commits
a6930e8
f02f0e7
8337f58
9bad4eb
c2fd962
c70b6e3
b731847
8794b30
8cae532
5a43bb6
7a098c3
ca2e0dc
692dfc4
0373cfc
b20bcd2
2ed5ace
eef4d9a
890b48b
7ccb669
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've introduced a new MetricsRegistry which individual classes may need to inject along with the previously created Tracer interface.
Is it possible to merge the needed interfaces to emit any tracing/metrics, etc. into a single wrapper which can help to avoid a lot of changes if a component decides to have only tracing today, but metrics in future or vice versa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mgodwan we have not done metrics injection yet, but I think injecting
Telemetry
orTelemetryService
instead would make sense (and cover your concerns).Check warning on line 32 in libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/noop/NoopCounter.java
Codecov / codecov/patch
libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/noop/NoopCounter.java#L32
Check warning on line 37 in libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/noop/NoopCounter.java
Codecov / codecov/patch
libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/noop/NoopCounter.java#L37