FreeBSD Java support #1014
FreeBSD Java support #1014
Conversation
Signed-off-by: hackacad <[email protected]>
|
✅ DCO Check Passed 30b8142 |
|
✅ Gradle Wrapper Validation success 30b8142 |
|
✅ Gradle Precommit success 30b8142 |
|
start gradle check |
| JAVA="$OPENSEARCH_HOME/jdk.app/Contents/Home/bin/java" | ||
| elif [ $OS = "freebsd" ]; then |
There was a problem hiding this comment.
Why wouldn't we be using the packaged Java version on FreeBSD?
There was a problem hiding this comment.
Same as for Node, Linux ELF isn't compatible and JAVA_HOME afaik not set by default on FreeBSD
There was a problem hiding this comment.
I see how this makes things better, but we do bundle a JDK under $OPENSEARCH_HOME, shouldn't we be then bundling a compatible JDK, and releasing a FreeBSD package instead of doing this? I'm thinking out loud, so bear with my FreeBSD ignorance.
There was a problem hiding this comment.
The best as far as FreeBSD is concerned is probably to ship a tarball which only contains the built java objects, and does not bundle the JDK (so a platform agnostic tarball).
It is not uncommon for FreeBSD ports to download such tarballs to build packages by just adding dependencies to the relevant ports (e.g. openjdk14, node), extracting this archive at the right location and providing utility scripts (e.g. rc.d init file).
|
This leads back to my first question in #1013 (comment) If you want to build a downloadable package for FreeBSD as well this would make sense. BUT it will be removed in an official FreeBSD port anyway. It’s the was it’s done there. (e.g. you can define every supported Java version and chose which one you want to use for it - https://wiki.freebsd.org/Ports/DEFAULT_VERSIONS ) |
Ok, this is clear. I think this PR is the right way to move forward. Today we don't work on FreeBSD anyway out of the box, so this would make it better by working in both dev and even prod bundle (albeit trailing some incompatible JDK and/or node). Because I don't know what I'm doing I'll ask @nknize for a second A-OK before merging. |
|
I'm merging this. |
Signed-off-by: hackacad [email protected]
Description
Adding support for FreeBSD userland Java (installe via port/pkg)
Issues Resolved
Adding reusable OS check ($OS) and location of Java on Darwin and FreeBSD
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.