-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update format for changelog, add developer documentation
Signed-off-by: Kunal Kotwani <[email protected]>
- Loading branch information
1 parent
a5a1090
commit f8986a9
Showing
4 changed files
with
53 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
- [Documentation Changes](#documentation-changes) | ||
- [Contributing Code](#contributing-code) | ||
- [Developer Certificate of Origin](#developer-certificate-of-origin) | ||
- [Changelog](#changelog) | ||
- [Review Process](#review-process) | ||
|
||
# Contributing to OpenSearch | ||
|
@@ -116,6 +117,52 @@ Signed-off-by: Jane Smith <[email protected]> | |
``` | ||
You may type this line on your own when writing your commit messages. However, if your user.name and user.email are set in your git configs, you can use `-s` or `--signoff` to add the `Signed-off-by` line to the end of the commit message. | ||
|
||
## Changelog | ||
|
||
OpenSearch maintains version specific changelog by enforcing a change to the ongoing [CHANGELOG](CHANGELOG.md) file adhering to the [Keep A Changelog](https://keepachangelog.com/en/1.0.0/) format. | ||
|
||
Briefly, the changes are curated by version, with the changes to the main branch added chronologically to `Unreleased` version. Further, each version has corresponding sections which list out the category of the change - `Added`, `Changed`, `Deprecated`, `Removed`, `Fixed`, `Security`. | ||
|
||
|
||
### How to add my changes to CHANGELOG](CHANGELOG.md)? | ||
|
||
As a contributor, you must ensure that every pull request has the changes listed out within the corresponding version and appropriate section of [CHANGELOG](CHANGELOG.md) file. | ||
|
||
Adding in the change is two step process - | ||
1. Add your changes to the corresponding section within the CHANGELOG file with dummy pull request information, publish the PR | ||
|
||
`Your change here ([#PR_NUMBER](PR_URL))` | ||
|
||
2. Update your changes with the corresponding `PR_NUMBER` and `PR_URL` and push out the new commit. | ||
|
||
For example, as a contributor, my change adds support for a new `FooBar` client, the changes would look like - | ||
|
||
``` | ||
# CHANGELOG | ||
Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | ||
## [ UNRELEASED ] | ||
### Added | ||
- ... | ||
- Add support for FooBar client ([#9999](https://github.com/opensearch-project/OpenSearch/pull/9999)) | ||
- Your change here ([#PR_NUMBER](PR_URL)) | ||
### Changed | ||
- ... | ||
### Deprecated | ||
- ... | ||
### Removed | ||
- ... | ||
### Fixed | ||
- ... | ||
### Security | ||
- ... | ||
``` | ||
|
||
## Review Process | ||
|
||
We deeply appreciate everyone who takes the time to make a contribution. We will review all contributions as quickly as possible. As a reminder, [opening an issue](https://github.com/opensearch-project/OpenSearch/issues/new/choose) discussing your change before you make it is the best way to smooth the PR process. This will prevent a rejection because someone else is already working on the problem, or because the solution is incompatible with the architectural direction. | ||
|