fix failing testSegment_ReplicationActionAction()

Signed-off-by: Rishikesh1159 <[email protected]>
opensearch-project · Feb 3, 2023 · c1ef1d4 · c1ef1d4
1 parent 08bc3d6
commit c1ef1d4
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 12 deletions.
diff --git a/...rg/opensearch/action/admin/indices/segment_replication/SegmentReplicationStatsAction.java b/...rg/opensearch/action/admin/indices/segment_replication/SegmentReplicationStatsAction.java
@@ -11,7 +11,7 @@
 import org.opensearch.action.ActionType;
 
 /**
- * Segment Replication information action
+ * Segment Replication stats information action
  *
  * @opensearch.internal
  */

diff --git a/...g/opensearch/action/admin/indices/segment_replication/SegmentReplicationStatsRequest.java b/...g/opensearch/action/admin/indices/segment_replication/SegmentReplicationStatsRequest.java
@@ -17,7 +17,7 @@
 import java.io.IOException;
 
 /**
- * Request for Segment Replication information
+ * Request for Segment Replication stats information
  *
  * @opensearch.internal
  */
@@ -30,7 +30,7 @@ public class SegmentReplicationStatsRequest extends BroadcastRequest<SegmentRepl
     private boolean completedOnly = false;
 
     /**
-     * Constructs a request for segment replication information for all shards
+     * Constructs a request for segment replication stats information for all shards
      */
     public SegmentReplicationStatsRequest() {
         this(Strings.EMPTY_ARRAY);
@@ -45,7 +45,7 @@ public SegmentReplicationStatsRequest(StreamInput in) throws IOException {
     }
 
     /**
-     * Constructs a request for segment replication information for all shards for the given indices
+     * Constructs a request for segment replication stats information for all shards for the given indices
      *
      * @param indices   Comma-separated list of indices about which to gather segment replication information
      */

diff --git a/...earch/action/admin/indices/segment_replication/SegmentReplicationStatsRequestBuilder.java b/...earch/action/admin/indices/segment_replication/SegmentReplicationStatsRequestBuilder.java
@@ -12,7 +12,7 @@
 import org.opensearch.client.OpenSearchClient;
 
 /**
- * Segment Replication information request builder.
+ * Segment Replication stats information request builder.
  *
  * @opensearch.internal
  */

diff --git a/.../opensearch/action/admin/indices/segment_replication/SegmentReplicationStatsResponse.java b/.../opensearch/action/admin/indices/segment_replication/SegmentReplicationStatsResponse.java
@@ -22,7 +22,7 @@
 import java.util.Map;
 
 /**
- * Information regarding the Segment Replication state of indices and their associated shards.
+ * Stats Information regarding the Segment Replication state of indices and their associated shards.
  *
  * @opensearch.internal
  */
@@ -35,7 +35,7 @@ public SegmentReplicationStatsResponse(StreamInput in) throws IOException {
     }
 
     /**
-     * Constructs segment replication information for a collection of indices and associated shards. Keeps track of how many total shards
+     * Constructs segment replication stats information for a collection of indices and associated shards. Keeps track of how many total shards
      * were seen, and out of those how many were successfully processed and how many failed.
      *
      * @param totalShards       Total count of shards seen

diff --git a/...arch/action/admin/indices/segment_replication/TransportSegmentReplicationStatsAction.java b/...arch/action/admin/indices/segment_replication/TransportSegmentReplicationStatsAction.java
@@ -40,7 +40,7 @@
 
 /**
  * Transport action for shard segment replication operation. This transport action does not actually
- * perform segment replication, it only reports on metrics of segment replication event (both active and complete).
+ * perform segment replication, it only reports on metrics/stats of segment replication event (both active and complete).
  *
  * @opensearch.internal
  */

diff --git a/server/src/test/java/org/opensearch/rest/action/cat/RestSegment_ReplicationActionTests.java b/server/src/test/java/org/opensearch/rest/action/cat/RestSegment_ReplicationActionTests.java
@@ -98,8 +98,7 @@ public void testSegment_ReplicationActionAction() {
             "stop_time_millis",
             "time",
             "stage",
-            "source_host",
-            "source_node",
+            "source_description",
             "target_host",
             "target_node",
             "files_fetched",
@@ -125,8 +124,7 @@ public void testSegment_ReplicationActionAction() {
                 state.getTimer().stopTime(),
                 new TimeValue(state.getTimer().time()),
                 state.getStage().name().toLowerCase(Locale.ROOT),
-                // state.getSourceDescription().getHostName(),
-                // state.getSourceDescription().getName(),
+                state.getSourceDescription(),
                 state.getTargetNode().getHostName(),
                 state.getTargetNode().getName(),
                 state.getIndex().recoveredFileCount(),