Address PR comments

Signed-off-by: Gaurav Bafna <[email protected]>
opensearch-project · Jun 16, 2024 · bd30dac · bd30dac
1 parent 031567c
commit bd30dac
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ## [Unreleased 2.x]
 ### Added
 - Add fingerprint ingest processor ([#13724](https://github.com/opensearch-project/OpenSearch/pull/13724))
+- [Remote Store] Rate limiter for remote store low priority uploads ([#14374](https://github.com/opensearch-project/OpenSearch/pull/14374/))
 
 ### Dependencies
 - Bump `org.gradle.test-retry` from 1.5.8 to 1.5.9 ([#13442](https://github.com/opensearch-project/OpenSearch/pull/13442))

diff --git a/...ternalClusterTest/java/org/opensearch/action/admin/indices/create/RemoteCloneIndexIT.java b/...ternalClusterTest/java/org/opensearch/action/admin/indices/create/RemoteCloneIndexIT.java
@@ -222,7 +222,7 @@ protected void setLowPriorityUploadRate(String repoName, String value) throws Ex
         RepositoryMetadata rmd = res.repositories().get(0);
         Settings.Builder settings = Settings.builder()
             .put("location", rmd.settings().get("location"))
-            .put("max_remote_upload_low_priority_bytes_per_sec", value);
+            .put("max_remote_low_priority_upload_bytes_per_sec", value);
         assertAcked(client().admin().cluster().preparePutRepository(repoName).setType(rmd.type()).setSettings(settings).get());
     }
 

diff --git a/server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java b/server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
@@ -451,7 +451,7 @@ private void readRepositoryMetadata(RepositoryMetadata repositoryMetadata) {
         remoteUploadRateLimiter = getRateLimiter(metadata.settings(), "max_remote_upload_bytes_per_sec", ByteSizeValue.ZERO);
         remoteUploadLowPriorityRateLimiter = getRateLimiter(
             metadata.settings(),
-            "max_remote_upload_low_priority_bytes_per_sec",
+            "max_remote_low_priority_upload_bytes_per_sec",
             ByteSizeValue.ZERO
         );
         remoteDownloadRateLimiter = getRateLimiter(metadata.settings(), "max_remote_download_bytes_per_sec", ByteSizeValue.ZERO);