Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: mgodwan <[email protected]>
  • Loading branch information
mgodwan committed Feb 1, 2024
1 parent 36925d2 commit 886757e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,5 @@ public static boolean isEnabled(Setting<Boolean> featureFlag) {
Property.NodeScope
);

public static final Setting<Boolean> DOC_ID_FUZZY_SET_SETTING = Setting.boolSetting(
DOC_ID_FUZZY_SET,
false,
Property.NodeScope
);
public static final Setting<Boolean> DOC_ID_FUZZY_SET_SETTING = Setting.boolSetting(DOC_ID_FUZZY_SET, false, Property.NodeScope);
}
4 changes: 2 additions & 2 deletions server/src/main/java/org/opensearch/index/IndexSettings.java
Original file line number Diff line number Diff line change
Expand Up @@ -1863,8 +1863,8 @@ private static <T> void verifyFeatureToSetDocIdFuzzySetSetting(Consumer<T> setti
if (FeatureFlags.isEnabled(DOC_ID_FUZZY_SET_SETTING)) {
settingUpdater.accept(val);
} else {
throw new IllegalArgumentException(String.format("Fuzzy set for optimizing doc id lookup " +
"cannot be enabled with feature flag %s set to false", FeatureFlags.DOC_ID_FUZZY_SET));
throw new IllegalArgumentException("Fuzzy set for optimizing doc id lookup " +
"cannot be enabled with feature flag [" + FeatureFlags.DOC_ID_FUZZY_SET + "] set to false");
}
}
}

0 comments on commit 886757e

Please sign in to comment.