PR feedback

Signed-off-by: Marc Handalian <[email protected]>
opensearch-project · Nov 30, 2023 · 3aeeaed · 3aeeaed
1 parent 6c93efb
commit 3aeeaed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/server/src/main/java/org/opensearch/index/shard/IndexShard.java b/server/src/main/java/org/opensearch/index/shard/IndexShard.java
@@ -1742,8 +1742,8 @@ public final boolean shouldProcessCheckpoint(ReplicationCheckpoint requestCheckp
         if (isSegmentReplicationAllowed() == false) {
             return false;
         }
-        ReplicationCheckpoint localCheckpoint = getLatestReplicationCheckpoint();
-        if (requestCheckpoint.isAheadOf(getLatestReplicationCheckpoint()) == false) {
+        final ReplicationCheckpoint localCheckpoint = getLatestReplicationCheckpoint();
+        if (requestCheckpoint.isAheadOf(localCheckpoint) == false) {
             logger.trace(
                 () -> new ParameterizedMessage(
                     "Ignoring new replication checkpoint - Shard is already on checkpoint {} that is ahead of {}",

diff --git a/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java b/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java
@@ -150,17 +150,15 @@ public SegmentReplicationTargetService(
 
     @Override
     protected void doStart() {
-        final ClusterService clusterService = indicesService.clusterService();
         if (DiscoveryNode.isDataNode(clusterService.getSettings())) {
             clusterService.addListener(this);
         }
     }
 
     @Override
     protected void doStop() {
-        final ClusterService clusterService = indicesService.clusterService();
         if (DiscoveryNode.isDataNode(clusterService.getSettings())) {
-            indicesService.clusterService().removeListener(this);
+            clusterService.removeListener(this);
         }
     }