[Rename] Refactored src/plugins/vis_type_table directory #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <[email protected]>
kavilla
reviewed
Mar 9, 2021
| @@ -31,7 +31,7 @@ jest.mock('./table_vis_response_handler', () => ({ | |||
| describe('interpreter/functions#table', () => { | |||
| const fn = functionWrapper(createTableVisFn()); | |||
| const context = { | |||
| type: 'kibana_datatable', | |||
| type: 'opensearch_dashboardsdatatable', | |||
There was a problem hiding this comment.
i think would be opensearch_dashboards_datatable
| @@ -39,14 +39,14 @@ interface RenderValue { | |||
| } | |||
|
|
|||
| export const createTableVisFn = (): ExpressionFunctionDefinition< | |||
| 'kibana_table', | |||
| 'opensearch_dashboardstable', | |||
There was a problem hiding this comment.
i believe opensearch_dashboards_table
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] Refactored src/plugins/vis_type_table directory Signed-off-by: Mihir Soni <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_table directory Signed-off-by: Mihir Soni <[email protected]>
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_table directory Signed-off-by: Mihir Soni <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 22, 2023
…opensearch-project#97) Signed-off-by: yuye-aws <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
…opensearch-project#97) Signed-off-by: yuye-aws <[email protected]>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
…opensearch-project#97) Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni [email protected]
Issue #, if available: #37
Description of changes: Refactored src/plugins/vis_type_table directory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.