Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Discover Test] TestID-69: Filtering. Add data-test-subj tags. #9028

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Backport 2.x] [Discover Test] TestID-69: Filtering. Add data-test-subj tags. #9028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plugins/data/public/ui/dataset_selector/dataset_explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ export const DatasetExplorer = ({
<EuiModalBody>
<div
className="datasetExplorer"
data-test-subj="datasetExplorerWindow"
style={{
gridTemplateColumns: `repeat(${
columnCount - 1
Expand Down
7 changes: 6 additions & 1 deletion src/plugins/data/public/ui/filter_bar/filter_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@ function FilterBarUI(props: Props) {

function renderItems() {
return props.filters.map((filter, i) => (
<EuiFlexItem key={i} grow={false} className="globalFilterBar__flexItem">
<EuiFlexItem
key={i}
grow={false}
className="globalFilterBar__flexItem"
data-test-subj="globalFilterBar"
>
<FilterItem
id={`${i}`}
intl={props.intl}
Expand Down
4 changes: 4 additions & 0 deletions src/plugins/data/public/ui/filter_bar/filter_editor/lib/filter_label.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ test('alias with warning status', () => {
:
<span
class="globalFilterLabel__value"
data-test-subj="globalFilterLabelValue"
>
Warning
</span>
Expand Down Expand Up @@ -125,6 +126,7 @@ test('alias with error status', () => {
:
<span
class="globalFilterLabel__value"
data-test-subj="globalFilterLabelValue"
>
Error
</span>
Expand All @@ -141,6 +143,7 @@ test('warning', () => {
:
<span
class="globalFilterLabel__value"
data-test-subj="globalFilterLabelValue"
>
Warning
</span>
Expand All @@ -157,6 +160,7 @@ test('error', () => {
:
<span
class="globalFilterLabel__value"
data-test-subj="globalFilterLabelValue"
>
Error
</span>
Expand Down
6 changes: 5 additions & 1 deletion src/plugins/data/public/ui/filter_bar/filter_editor/lib/filter_label.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@ export default function FilterLabel({ filter, valueLabel, filterLabelStatus }: F
);

const getValue = (text?: string) => {
return <span className="globalFilterLabel__value">{text}</span>;
return (
<span className="globalFilterLabel__value" data-test-subj="globalFilterLabelValue">
{text}
</span>
);
};

if (filter.meta.alias !== null) {
Expand Down
Loading