Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the osd-plugin-generator template to reference the correct button #9014

Merged
merged 4 commits into from
Dec 6, 2024
Merged

fix: update the osd-plugin-generator template to reference the correct button #9014

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5db2aab
fix: update the osd-plugin-generator template to reference the correc…
angle943 Dec 5, 2024
de3076d
remove the size prop
angle943 Dec 6, 2024
620f910
change it to EuiButton
angle943 Dec 6, 2024
93b7e33
Merge branch 'main' into fix-plugin-generator-template
angle943 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/osd-plugin-generator/template/public/components/app.tsx.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ import { CoreStart } from '<%= importFromRoot('src/core/public') %>';
defaultMessage="Last timestamp: {time}" values={{ time: timestamp ? timestamp
: 'Unknown' }} />
</p>
<EuiButton type="primary" size="s" onClick={onClickHandler}>
<EuiSmallButton type="primary" size="s" onClick={onClickHandler}>
<FormattedMessage id="<%= camelCase(name) %>.buttonText"
defaultMessage="<%= hasServer ? 'Get data' : 'Click me' %>" />
</EuiButton>
</EuiSmallButton>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix the import by change EuiSmallButton to EuiButton, so the page style get unchanged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure i will do that change

</EuiText>
</EuiPageContentBody>
</EuiPageContent>
Expand Down
Loading