-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Clear the attribute of error objects #9003
Merged
ruanyl
merged 3 commits into
opensearch-project:main
from
yubonluo:clear-error-attribute
Dec 5, 2024
Merged
[Workspace] Clear the attribute of error objects #9003
ruanyl
merged 3 commits into
opensearch-project:main
from
yubonluo:clear-error-attribute
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
December 4, 2024 08:15
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9003 +/- ##
==========================================
+ Coverage 60.84% 60.85% +0.01%
==========================================
Files 3808 3808
Lines 91193 91193
Branches 14408 14408
==========================================
+ Hits 55485 55499 +14
+ Misses 32165 32152 -13
+ Partials 3543 3542 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
previously approved these changes
Dec 4, 2024
Hailong-am
previously approved these changes
Dec 4, 2024
we don't need change log for this PR as it fix a unrelease feature. |
github-actions
bot
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Dec 4, 2024
opensearch-changeset-bot
bot
dismissed stale reviews from Hailong-am and ruanyl
via
December 4, 2024 08:59
ff94dc1
Hailong-am
approved these changes
Dec 4, 2024
ruanyl
approved these changes
Dec 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
* clear the attribute of error objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #9003 created/updated * Changeset file for PR #9003 deleted --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 36bf5e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Dec 10, 2024
* clear the attribute of error objects * Changeset file for PR #9003 created/updated * Changeset file for PR #9003 deleted --------- (cherry picked from commit 36bf5e8) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ArgusLi
pushed a commit
to ArgusLi/OpenSearch-Dashboards
that referenced
this pull request
Dec 11, 2024
…9003) * clear the attribute of error objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#9003 created/updated * Changeset file for PR opensearch-project#9003 deleted --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ArgusLi
pushed a commit
to ArgusLi/OpenSearch-Dashboards
that referenced
this pull request
Dec 17, 2024
…9003) * clear the attribute of error objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#9003 created/updated * Changeset file for PR opensearch-project#9003 deleted --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
distinguished-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
workspace
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clear the attribute of error objects
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration