Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Clear the attribute of error objects #9003

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Dec 4, 2024

Description

Clear the attribute of error objects

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.85%. Comparing base (fe616e7) to head (ff94dc1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9003      +/-   ##
==========================================
+ Coverage   60.84%   60.85%   +0.01%     
==========================================
  Files        3808     3808              
  Lines       91193    91193              
  Branches    14408    14408              
==========================================
+ Hits        55485    55499      +14     
+ Misses      32165    32152      -13     
+ Partials     3543     3542       -1     
Flag Coverage Δ
Linux_1 29.03% <ø> (ø)
Linux_2 56.38% <ø> (ø)
Linux_3 37.90% <ø> (+<0.01%) ⬆️
Linux_4 28.99% <ø> (ø)
Windows_1 29.06% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <ø> (ø)
Windows_4 28.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Dec 4, 2024
Hailong-am
Hailong-am previously approved these changes Dec 4, 2024
@Hailong-am
Copy link
Collaborator

we don't need change log for this PR as it fix a unrelease feature.

@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Dec 4, 2024
@opensearch-changeset-bot opensearch-changeset-bot bot dismissed stale reviews from Hailong-am and ruanyl via ff94dc1 December 4, 2024 08:59
@ruanyl ruanyl merged commit 36bf5e8 into opensearch-project:main Dec 5, 2024
69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 5, 2024
* clear the attribute of error objects

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #9003 created/updated

* Changeset file for PR #9003 deleted

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 36bf5e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Dec 10, 2024
* clear the attribute of error objects



* Changeset file for PR #9003 created/updated

* Changeset file for PR #9003 deleted

---------



(cherry picked from commit 36bf5e8)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ArgusLi pushed a commit to ArgusLi/OpenSearch-Dashboards that referenced this pull request Dec 11, 2024
…9003)

* clear the attribute of error objects

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#9003 created/updated

* Changeset file for PR opensearch-project#9003 deleted

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ArgusLi pushed a commit to ArgusLi/OpenSearch-Dashboards that referenced this pull request Dec 17, 2024
…9003)

* clear the attribute of error objects

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#9003 created/updated

* Changeset file for PR opensearch-project#9003 deleted

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants