Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[augmenter] do not support datasources with no version (#8915)" #8925

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Nov 25, 2024

This reverts commit 539675e.

There is a known issue with the bundled JS after this change, when trying to render eligible visualizations. The AD/Alerting options fail to render, due to issues fetching the underlying getIndexPatterns fn within isEligibleForVisLayers. This is due to how the JS modules are bundled along with a mismatch on when these functions are defined in setup()/start() phases of the plugins.

Future work to add this functionality in a safe manner is tracked in #8924.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ohltyler
Copy link
Member Author

backport is not needed as the backport PR for the original change was closed before merging.

Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@ohltyler
Copy link
Member Author

@kavilla / @ashwin-pc please take a look, thanks!

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (539675e) to head (69c77ed).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...izations/public/embeddable/visualize_embeddable.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8925      +/-   ##
==========================================
- Coverage   60.88%   60.87%   -0.01%     
==========================================
  Files        3802     3802              
  Lines       91070    91060      -10     
  Branches    14374    14370       -4     
==========================================
- Hits        55444    55437       -7     
+ Misses      32085    32084       -1     
+ Partials     3541     3539       -2     
Flag Coverage Δ
Linux_1 29.01% <50.00%> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <50.00%> (+<0.01%) ⬆️
Linux_4 29.00% <ø> (ø)
Windows_1 29.03% <50.00%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <50.00%> (-0.01%) ⬇️
Windows_4 29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianleh
Copy link
Member

tianleh commented Dec 3, 2024

Can you check the DCO and codecov/patch failures? @ohltyler

@ohltyler
Copy link
Member Author

ohltyler commented Dec 3, 2024

Can you check the DCO and codecov/patch failures? @ohltyler

Set DCO to pass - originally failed since the commit was auto-generated using git revert.

Codecov failure can be ignored; this is just reverting a single commit/change.

@ohltyler ohltyler merged commit 98e9042 into opensearch-project:main Dec 4, 2024
70 of 72 checks passed
@ohltyler ohltyler deleted the revert-vis-augmenter branch December 4, 2024 17:48
ArgusLi pushed a commit to ArgusLi/OpenSearch-Dashboards that referenced this pull request Dec 11, 2024
silva-qa pushed a commit to silva-qa/OpenSearch-Dashboards that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants