-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[augmenter] do not support datasources with no version (#8915)" #8925
Revert "[augmenter] do not support datasources with no version (#8915)" #8925
Conversation
…earch-project#8915)" This reverts commit 539675e.
backport is not needed as the backport PR for the original change was closed before merging. |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
@kavilla / @ashwin-pc please take a look, thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8925 +/- ##
==========================================
- Coverage 60.88% 60.87% -0.01%
==========================================
Files 3802 3802
Lines 91070 91060 -10
Branches 14374 14370 -4
==========================================
- Hits 55444 55437 -7
+ Misses 32085 32084 -1
+ Partials 3541 3539 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you check the DCO and codecov/patch failures? @ohltyler |
Set DCO to pass - originally failed since the commit was auto-generated using Codecov failure can be ignored; this is just reverting a single commit/change. |
…earch-project#8915)" (opensearch-project#8925) This reverts commit 539675e. Signed-off-by: Federico Silva <[email protected]>
This reverts commit 539675e.
There is a known issue with the bundled JS after this change, when trying to render eligible visualizations. The AD/Alerting options fail to render, due to issues fetching the underlying
getIndexPatterns
fn withinisEligibleForVisLayers
. This is due to how the JS modules are bundled along with a mismatch on when these functions are defined insetup()
/start()
phases of the plugins.Future work to add this functionality in a safe manner is tracked in #8924.
Changelog
Check List
yarn test:jest
yarn test:jest_integration