Fix SurroundingDocsView with URI encoded chars in document id #8869
Conversation
When viewing surrounding documents of a document which id contains chars such as `@` or `+`, these chars are encoded, preventing OpenSearch from finding the requested document. Decode the id to transform back the URI encoded chars to the actual chars in the document id to find it and unbreak the feature. Fixes opensearch-project#5711 Signed-off-by: Romain Tartière <[email protected]>
smortex
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
Skip-Changelog
smortex
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8869 +/- ##
=======================================
Coverage 60.93% 60.93%
=======================================
Files 3800 3800
Lines 90878 90878
Branches 14323 14323
=======================================
Hits 55380 55380
Misses 31968 31968
Partials 3530 3530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When viewing surrounding documents of a document which id contains chars
such as
@or+, these chars are encoded, preventing OpenSearch fromfinding the requested document.
Decode the id to transform back the URI encoded chars to the actual
chars in the document id to find it and unbreak the feature.
Fixes #5711
Signed-off-by: Romain Tartière [email protected]
Changelog