Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Discover] fix error handling in query enhancement facet #8748

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Backport 2.x] [Discover] fix error handling in query enhancement facet #8748

merged 1 commit into from
Oct 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2f31914 from #8743.

@github-actions @opensearch-changeset-bot
[Discover] fix error handling in query enhancement facet (#8743)
7fb989c 
* [Discover] fix error handling in query enhancement facet

---------

Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2f31914)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports all-star-contributor discover-next v2.18.0 labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (21e84cb) to head (7fb989c).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/plugins/query_enhancements/common/utils.ts 0.00% 2 Missing ⚠️
...c/plugins/query_enhancements/server/utils/facet.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8748      +/-   ##
==========================================
- Coverage   60.82%   60.82%   -0.01%     
==========================================
  Files        3797     3797              
  Lines       90678    90679       +1     
  Branches    14254    14254              
==========================================
  Hits        55159    55159              
- Misses      32028    32029       +1     
  Partials     3491     3491
Flag Coverage Δ
Linux_1 29.07% <ø> (ø)
Linux_2 56.53% <ø> (ø)
Linux_3 37.60% <ø> (ø)
Linux_4 29.95% <0.00%> (-0.01%) ⬇️
Windows_1 29.09% <ø> (ø)
Windows_2 56.49% <ø> (ø)
Windows_3 37.60% <ø> (ø)
Windows_4 29.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 09348cc into 2.x Oct 30, 2024
69 of 72 checks passed
@github-actions github-actions bot deleted the backport/backport-8743-to-2.x branch October 30, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMoo-Miki @ananzh