[Discover] notify user about field_type_tolerance for SQL/PPL in query footer #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y footer Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
huyaboo
as code owners
opensearch-changeset-bot bot
added a commit
to joshuali925/OpenSearch-Dashboards
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Joshua Li <[email protected]>
joshuali925
force-pushed
the
field_type_tolerance
branch
from
c1e5630
to
428afba
Compare
ashwin-pc
reviewed
Oct 25, 2024
| @@ -87,13 +92,16 @@ export class QueryEnhancementsPlugin | |||
| editor: enhancedPPLQueryEditor, | |||
| editorSupportedAppNames: ['discover'], | |||
| supportedAppNames: ['discover', 'data-explorer'], | |||
| inputFooterItems: { | |||
There was a problem hiding this comment.
Why cant we reuse the editor prop or pass it directly in the editor?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8702 +/- ##
=======================================
Coverage 60.84% 60.85%
=======================================
Files 3793 3794 +1
Lines 90486 90518 +32
Branches 14212 14221 +9
=======================================
+ Hits 55057 55081 +24
- Misses 31939 31943 +4
- Partials 3490 3494 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
|
this is no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add icon in query editor footer to notify user about limitation in array type in SQL/PPL responses. The icon is present if
plugins.query.field_type_toleranceis unset or set tofalse, clicking on it will open a popover with details. The popover is open by default if user hasn't seen it before (state persisted in localStorage).This only applies to OpenSearch data sources. If request to cluster settings API failed, it will not display the icon.
This PR also renames
SQLtoOpenSearch SQLIssues Resolved
related: opensearch-project/sql#3118
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration