-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add framework to show related indexed views inside dataset selector and show banner in the Discover canvas for the selected dataset #8701
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8701 +/- ##
==========================================
- Coverage 60.75% 60.75% -0.01%
==========================================
Files 3798 3798
Lines 90690 90729 +39
Branches 14277 14286 +9
==========================================
+ Hits 55101 55123 +22
- Misses 32090 32108 +18
+ Partials 3499 3498 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan for unit tests?
Also, can you double check ci failures? One I think is a known issue but the other i'm not sure about
For now all changes are behind a flag, unit tests will be added as fast follow next week |
6acb02c
to
6d69ff3
Compare
…s in dataset selector Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
4db89fd
to
03fbf03
Compare
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Description
In this PR we add support for
Issues Resolved
New feature
Screenshot
Note: Below screenshots were produced by making changes to the S3 type config for testing and are not part of this PR since this PR is only adding the framework.
Testing the changes
Set up workspace with query enhancements enabled
Changelog
Check List
yarn test:jest
yarn test:jest_integration