Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper error handling in dev tools with MDS #8696

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhongnansu
Copy link
Member

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (9a25d0d) to head (b1c460f).

Files with missing lines Patch % Lines
.../server/routes/api/console/proxy/create_handler.ts 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8696      +/-   ##
==========================================
- Coverage   60.84%   60.84%   -0.01%     
==========================================
  Files        3793     3793              
  Lines       90486    90486              
  Branches    14212    14212              
==========================================
- Hits        55057    55056       -1     
- Misses      31939    31940       +1     
  Partials     3490     3490              
Flag Coverage Δ
Linux_1 29.07% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.66% <50.00%> (-0.01%) ⬇️
Linux_4 29.84% <ø> (ø)
Windows_1 29.08% <ø> (ø)
Windows_2 56.35% <ø> (ø)
Windows_3 37.67% <50.00%> (+<0.01%) ⬆️
Windows_4 29.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant