[workspace] update search bar layout and align workspace selector #8649

Hailong-am · 2024-10-18T09:49:13Z

Description

Adjust workspace selector to align with left nav items
Let search bar popup when click on it
Use normal font weight for search items text

Issues Resolved

Screenshot

Before

After

items show with normal font weight

workspace selector align with left nav

Testing the changes

enable workspace and new homepage by putting this into yml

workspace.enabled: true
uiSettings:
  overrides:
    "home:useNewHomePage": true

start OSD yarn start

Changelog

fix: finetune search bar and workspace selector style

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-10-18T09:49:53Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-10-18T10:23:35Z

Codecov Report

Attention: Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (5d74306) to head (b36bc22).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...core/public/chrome/ui/header/header_search_bar.tsx	89.47%	3 Missing and 1 partial ⚠️
.../components/global_search/search_pages_command.tsx	42.85%	2 Missing and 2 partials ⚠️
...pace/public/components/global_search/page_item.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8649   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files        3793     3793           
  Lines       90381    90386    +5     
  Branches    14185    14190    +5     
=======================================
+ Hits        55006    55010    +4     
+ Misses      31898    31897    -1     
- Partials     3477     3479    +2

Flag	Coverage Δ
Linux_1	`29.09% <6.38%> (+<0.01%)`	⬆️
Linux_2	`56.41% <89.47%> (+0.01%)`	⬆️
Linux_3	`37.69% <0.00%> (+<0.01%)`	⬆️
Linux_4	`29.82% <0.00%> (+<0.01%)`	⬆️
Windows_1	`29.11% <6.38%> (+<0.01%)`	⬆️
Windows_2	`56.36% <89.47%> (+0.01%)`	⬆️
Windows_3	`37.69% <0.00%> (+<0.01%)`	⬆️
Windows_4	`29.82% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hailong Cui <[email protected]>

SuZhou-Joe · 2024-10-21T05:32:53Z

May I know if this misalignment is by intension?

SuZhou-Joe · 2024-10-21T05:35:12Z

src/core/public/chrome/ui/header/collapsible_nav_group_enabled_top.tsx

+              flush="both"
+              {...homeLinkProps}
+              onClick={onIconClick}
+              className="homeIcon"


Suggested change

className="homeIcon"

className="navGroupEnabledHomeIcon"

Will the class name conflict with the existing homeIcon?

updated to navGroupEnabledHomeIcon as suggested.

Signed-off-by: Hailong Cui <[email protected]>

Hailong-am · 2024-10-21T06:08:10Z

May I know if this misalignment is by intension?

Yes,

Signed-off-by: Hailong Cui <[email protected]>

ruanyl · 2024-10-22T07:57:25Z

src/core/public/chrome/ui/header/header_search_bar.tsx

+        {isPopoverOpen && (
+          <EuiPopover
+            panelStyle={{ minWidth: '400px', minHeight: '100px' }}
+            button={<></>}


Q: why using <></> as the popover anchor?

Popover will always show with its anchor, the purpose of this will make it looks like only popover displayed. And button is required, so i put an empty element here.

I see, thanks :)

) * update search bar layout Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #8649 created/updated * update search bar layout Signed-off-by: Hailong Cui <[email protected]> * update test case Signed-off-by: Hailong Cui <[email protected]> * style update Signed-off-by: Hailong Cui <[email protected]> * typo Signed-off-by: Hailong Cui <[email protected]> * support search nav items by its parent title Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 79fed30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) (#8687) * update search bar layout * Changeset file for PR #8649 created/updated * update search bar layout * update test case * style update * typo * support search nav items by its parent title * address review comments --------- (cherry picked from commit 79fed30) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ensearch-project#8649) * update search bar layout Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR opensearch-project#8649 created/updated * update search bar layout Signed-off-by: Hailong Cui <[email protected]> * update test case Signed-off-by: Hailong Cui <[email protected]> * style update Signed-off-by: Hailong Cui <[email protected]> * typo Signed-off-by: Hailong Cui <[email protected]> * support search nav items by its parent title Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the all-star-contributor label Oct 18, 2024

github-actions bot added failed changeset and removed failed changeset labels Oct 18, 2024

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 18, 2024

Changeset file for PR opensearch-project#8649 created/updated

ee49a59

Hailong-am changed the title ~~[workspace] update search bar layout~~ [workspace] update search bar layout and align workspace selector Oct 18, 2024

Hailong-am and others added 3 commits October 18, 2024 20:46

update search bar layout

698c124

Signed-off-by: Hailong Cui <[email protected]>

Changeset file for PR opensearch-project#8649 created/updated

0744c88

update search bar layout

721eb42

Signed-off-by: Hailong Cui <[email protected]>

Hailong-am force-pushed the search_bar_layout branch from 6149e21 to 721eb42 Compare October 18, 2024 12:47

Hailong-am added backport 2.x workspace labels Oct 18, 2024

Hailong-am added 3 commits October 19, 2024 08:34

update test case

f9852f6

Signed-off-by: Hailong Cui <[email protected]>

Merge remote-tracking branch 'upstream/main' into search_bar_layout

fe0d207

Merge branch 'main' into search_bar_layout

54eb759

Hailong-am marked this pull request as ready for review October 19, 2024 16:02

Hailong-am requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq and bandinib-amzn as code owners October 19, 2024 16:02

Hailong-am requested review from SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27, virajsanghvi, sejli, joshuali925 and huyaboo as code owners October 19, 2024 16:02

Merge remote-tracking branch 'upstream/main' into search_bar_layout

b1a55e9

Hailong-am added the v2.18.0 label Oct 21, 2024

Hailong-am added 2 commits October 21, 2024 11:29

style update

62a579e

Signed-off-by: Hailong Cui <[email protected]>

typo

18f7e2f

Signed-off-by: Hailong Cui <[email protected]>

SuZhou-Joe reviewed Oct 21, 2024

View reviewed changes

support search nav items by its parent title

f8470da

Signed-off-by: Hailong Cui <[email protected]>

Hailong-am added 2 commits October 21, 2024 14:17

address review comments

6ab80cd

Signed-off-by: Hailong Cui <[email protected]>

Merge branch 'main' into search_bar_layout

b36bc22

SuZhou-Joe approved these changes Oct 22, 2024

View reviewed changes

ruanyl reviewed Oct 22, 2024

View reviewed changes

ruanyl approved these changes Oct 23, 2024

View reviewed changes

Hailong-am merged commit 79fed30 into opensearch-project:main Oct 23, 2024
68 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024

[Backport 2.x] [workspace] update search bar layout and align workspace selector #8687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[workspace] update search bar layout and align workspace selector #8649

[workspace] update search bar layout and align workspace selector #8649

Hailong-am commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024

codecov bot commented Oct 18, 2024 •

edited

Loading

SuZhou-Joe commented Oct 21, 2024

SuZhou-Joe Oct 21, 2024

Hailong-am Oct 21, 2024

Hailong-am commented Oct 21, 2024

ruanyl Oct 22, 2024

Hailong-am Oct 22, 2024

ruanyl Oct 23, 2024

[workspace] update search bar layout and align workspace selector #8649

[workspace] update search bar layout and align workspace selector #8649

Conversation

Hailong-am commented Oct 18, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Oct 18, 2024

❌ Empty Changelog Section

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

SuZhou-Joe commented Oct 21, 2024

SuZhou-Joe Oct 21, 2024

Choose a reason for hiding this comment

Hailong-am Oct 21, 2024

Choose a reason for hiding this comment

Hailong-am commented Oct 21, 2024

ruanyl Oct 22, 2024

Choose a reason for hiding this comment

Hailong-am Oct 22, 2024

Choose a reason for hiding this comment

ruanyl Oct 23, 2024

Choose a reason for hiding this comment

Hailong-am commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading