-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Documentation for various languages in Discover #8636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suchit Sahoo <[email protected]>
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 17, 2024 22:05
LDrago27
added
v2.18.0
discover
for discover reinvent
discover-next
and removed
all-star-contributor
labels
Oct 17, 2024
github-actions
bot
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Oct 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8636 +/- ##
==========================================
- Coverage 60.94% 60.88% -0.06%
==========================================
Files 3790 3792 +2
Lines 90306 90274 -32
Branches 14154 14156 +2
==========================================
- Hits 55034 54966 -68
- Misses 31815 31835 +20
- Partials 3457 3473 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Suchit Sahoo <[email protected]>
ananzh
previously approved these changes
Oct 18, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
ananzh
approved these changes
Oct 18, 2024
ashwin-pc
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Fix Documentation for various languages in Discover Signed-off-by: Suchit Sahoo <[email protected]> * Update Snapshots Signed-off-by: Suchit Sahoo <[email protected]> * Update the Lucene Language Reference Signed-off-by: Suchit Sahoo <[email protected]> --------- Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit e5b7067) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Fix Documentation for various languages in Discover * Update Snapshots * Update the Lucene Language Reference --------- (cherry picked from commit e5b7067) Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2024
…ct#8636) * Fix Documentation for various languages in Discover Signed-off-by: Suchit Sahoo <[email protected]> * Update Snapshots Signed-off-by: Suchit Sahoo <[email protected]> * Update the Lucene Language Reference Signed-off-by: Suchit Sahoo <[email protected]> --------- Signed-off-by: Suchit Sahoo <[email protected]>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…ct#8636) * Fix Documentation for various languages in Discover Signed-off-by: Suchit Sahoo <[email protected]> * Update Snapshots Signed-off-by: Suchit Sahoo <[email protected]> * Update the Lucene Language Reference Signed-off-by: Suchit Sahoo <[email protected]> --------- Signed-off-by: Suchit Sahoo <[email protected]>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…ct#8636) * Fix Documentation for various languages in Discover Signed-off-by: Suchit Sahoo <[email protected]> * Update Snapshots Signed-off-by: Suchit Sahoo <[email protected]> * Update the Lucene Language Reference Signed-off-by: Suchit Sahoo <[email protected]> --------- Signed-off-by: Suchit Sahoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
discover
for discover reinvent
discover-next
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
v2.18.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the documentation links for the various languages in the discover query bar.
Issues Resolved
Screenshot
Testing the changes
DocumentationFIx.mp4
Changelog
Check List
yarn test:jest
yarn test:jest_integration