Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation for various languages in Discover #8636

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

LDrago27
Copy link
Collaborator

Description

Fix the documentation links for the various languages in the discover query bar.

Issues Resolved

Screenshot

Testing the changes

DocumentationFIx.mp4

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (5c8b2e3) to head (3d8f04c).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...string/language_service/lib/language_reference.tsx 16.66% 5 Missing ⚠️
...ng/language_service/lib/dql_language_reference.tsx 42.85% 4 Missing ⚠️
...language_service/lib/lucene_language_reference.tsx 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8636      +/-   ##
==========================================
- Coverage   60.94%   60.88%   -0.06%     
==========================================
  Files        3790     3792       +2     
  Lines       90306    90274      -32     
  Branches    14154    14156       +2     
==========================================
- Hits        55034    54966      -68     
- Misses      31815    31835      +20     
- Partials     3457     3473      +16     
Flag Coverage Δ
Linux_1 29.11% <22.72%> (-0.18%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <40.90%> (+<0.01%) ⬆️
Linux_4 29.81% <22.72%> (-0.10%) ⬇️
Windows_1 29.13% <22.72%> (-0.18%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <40.90%> (+<0.01%) ⬆️
Windows_4 29.81% <22.72%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Suchit Sahoo <[email protected]>
ananzh
ananzh previously approved these changes Oct 18, 2024
@ashwin-pc ashwin-pc merged commit e5b7067 into opensearch-project:main Oct 18, 2024
67 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
* Fix Documentation for various languages in Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Update Snapshots

Signed-off-by: Suchit Sahoo <[email protected]>

* Update the Lucene Language Reference

Signed-off-by: Suchit Sahoo <[email protected]>

---------

Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e5b7067)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi pushed a commit that referenced this pull request Oct 18, 2024
* Fix Documentation for various languages in Discover



* Update Snapshots



* Update the Lucene Language Reference



---------


(cherry picked from commit e5b7067)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
…ct#8636)

* Fix Documentation for various languages in Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Update Snapshots

Signed-off-by: Suchit Sahoo <[email protected]>

* Update the Lucene Language Reference

Signed-off-by: Suchit Sahoo <[email protected]>

---------

Signed-off-by: Suchit Sahoo <[email protected]>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…ct#8636)

* Fix Documentation for various languages in Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Update Snapshots

Signed-off-by: Suchit Sahoo <[email protected]>

* Update the Lucene Language Reference

Signed-off-by: Suchit Sahoo <[email protected]>

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…ct#8636)

* Fix Documentation for various languages in Discover

Signed-off-by: Suchit Sahoo <[email protected]>

* Update Snapshots

Signed-off-by: Suchit Sahoo <[email protected]>

* Update the Lucene Language Reference

Signed-off-by: Suchit Sahoo <[email protected]>

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover for discover reinvent discover-next Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants