Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discover-new] fix spelling for localstorage key name #8632

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[discover-new] fix spelling for localstorage key name #8632

wants to merge 2 commits into from

Conversation

hanzhinstas
Copy link

@hanzhinstas hanzhinstas commented Oct 17, 2024 •
edited
Loading

Description

Key name was introduced with typo

Testing the changes

https://dictionary.cambridge.org/dictionary/english/experience

Changelog

  • fix: Fixed typo in option name that disabled legacy Discover UI. Those using new Discover will have to re-enable it manually in Discover

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 17, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (32b11de) to head (151f037).
Report is 44 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8632      +/-   ##
==========================================
+ Coverage   60.86%   60.87%   +0.01%     
==========================================
  Files        3790     3790              
  Lines       90235    90235              
  Branches    14144    14144              
==========================================
+ Hits        54924    54934      +10     
+ Misses      31846    31835      -11     
- Partials     3465     3466       +1
Flag Coverage Δ
Linux_1 29.08% <100.00%> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <100.00%> (-0.01%) ⬇️
Linux_4 29.80% <ø> (ø)
Windows_1 29.11% <100.00%> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <100.00%> (ø)
Windows_4 29.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla
kavilla reviewed Oct 17, 2024
View reviewed changes
src/plugins/discover/public/application/components/utils/local_storage.ts
@@ -5,7 +5,7 @@

import { Storage } from '../../../../../opensearch_dashboards_utils/public';

export const NEW_DISCOVER_KEY = 'discover:newExpereince';
export const NEW_DISCOVER_KEY = 'discover:newExperience';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this always stuck out like a red thumb for me. One risk to call out here is that previous users who set this will need to reset this. Should we call this out in a changelog?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like that?

fixed typo in option name that disabled legacy Discover UI. Those using new Discover have to re-enable it once again

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that works

@kavilla kavilla added the discover for discover reinvent label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fixed typo in option name that disabled legacy Discover UI. Those using new Discover have to re-enable it once again". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@ananzh ananzh added the v2.19.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla left review comments

@LDrago27 LDrago27 LDrago27 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
discover for discover reinvent failed changeset first-time-contributor v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanzhinstas @kavilla @ashwin-pc @LDrago27 @ananzh