Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Add a MetricsRecorder plugin for metrics reporting #8628

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Oct 17, 2024

Description

Add a MetricsRecorder plugin for metrics reporting.

Issues Resolved

#8625

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • [] Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (4a2416f) to head (ec693ef).
Report is 55 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8628   +/-   ##
=======================================
  Coverage   60.95%   60.95%           
=======================================
  Files        3792     3793    +1     
  Lines       90355    90362    +7     
  Branches    14170    14172    +2     
=======================================
+ Hits        55072    55078    +6     
+ Misses      31822    31820    -2     
- Partials     3461     3464    +3     
Flag Coverage Δ
Linux_1 29.34% <ø> (+0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <ø> (ø)
Linux_4 ?
Windows_1 29.35% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <ø> (-0.01%) ⬇️
Windows_4 29.92% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am
Copy link
Collaborator

Can we use telemetry plugin?

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not rush a new reporting plugin without due consideration given to the original one. I dont agree with some of the assumptions made in the original issue. I'll call out my concerns there. Lets have a discussion on the original issue before proceeding with this change in core. lets discuss the drawbacks with the useage collection plugin and why we cant find workarounds before adding a new one here.

@chishui
Copy link
Contributor Author

chishui commented Oct 18, 2024

Can we use telemetry plugin?

telemetry plugin is built on top of usage_collection and it only collects metrics scattered in different places, it doesn't have mechanism to store metrics.

@chishui chishui changed the title Add a MetricsRecorder plugin for metrics reporting [POC] Add a MetricsRecorder plugin for metrics reporting Oct 18, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@chishui
Copy link
Contributor Author

chishui commented Oct 28, 2024

@seraphjiang @zengyan-amazon could you take a look?

@ananzh ananzh added the v2.19.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants