Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Update default workspace permission and users config support wildcard #8617

Merged
merged 9 commits into from
Oct 17, 2024
Merged

[Workspace] Update default workspace permission and users config support wildcard #8617

merged 9 commits into from
Oct 17, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Oct 17, 2024 •
edited
Loading

Description

Update default workspace permission and support wildcard.

  1. Without configuring OSD admin in the config.yml, anyone will not be OSD admin.
  2. Support wildcard * in users config. With configuring * in the config.yml (opensearchDashboards.dashboardAdmin.users: ["*"]), anyone will be OSD admin.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • refactor: [Workspace] Update default OSD admin config permission and support wildcard.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
optimize the code
2b206cb 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
Merge branch '2.17/refactor-osd-admin-logic' of github.com:yubonluo/O…
ceb670d 
…penSearch-Dashboards into 2.17/refactor-osd-admin-logic
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (5c8b2e3) to head (0d27d7e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8617   +/-   ##
=======================================
  Coverage   60.94%   60.94%           
=======================================
  Files        3790     3790           
  Lines       90306    90305    -1     
  Branches    14154    14154           
=======================================
+ Hits        55034    55039    +5     
+ Misses      31815    31809    -6     
  Partials     3457     3457
Flag Coverage Δ
Linux_1 29.30% <100.00%> (+0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <ø> (ø)
Linux_4 29.91% <ø> (ø)
Windows_1 29.32% <100.00%> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <ø> (ø)
Windows_4 29.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yubonluo yubonluo changed the title [Workspace] Update default workspace permission and support wildcard [Workspace] Update default workspace permission and users config support wildcard Oct 17, 2024
@yubonluo
optimize the code
2da8afe 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
5b57a7d 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
0d27d7e 
Signed-off-by: yubonluo <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 1d6190d into opensearch-project:main Oct 17, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Update default workspace permission and users config supp…
55e710f 
…ort wildcard (#8617)

* Update default workspace permission and support wildcard

Signed-off-by: yubonluo <[email protected]>

* update the config yaml file

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #8617 created/updated

* Changeset file for PR #8617 created/updated

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1d6190d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 17, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Oct 17, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Update default workspace permission and users config supp…
6fc2aa4 
…ort wildcard (#8617) (#8627)

* Update default workspace permission and support wildcard



* update the config yaml file



* Changeset file for PR #8617 created/updated

* Changeset file for PR #8617 created/updated

* optimize the code



* optimize the code



* optimize the code



* optimize the code



---------



(cherry picked from commit 1d6190d)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
@yubonluo @opensearch-changeset-bot @amsiglan
[Workspace] Update default workspace permission and users config supp…
b884e94 
…ort wildcard (opensearch-project#8617)

* Update default workspace permission and support wildcard

Signed-off-by: yubonluo <[email protected]>

* update the config yaml file

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#8617 created/updated

* Changeset file for PR opensearch-project#8617 created/updated

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
@yubonluo @opensearch-changeset-bot @sejli
[Workspace] Update default workspace permission and users config supp…
ad699cb 
…ort wildcard (opensearch-project#8617)

* Update default workspace permission and support wildcard

Signed-off-by: yubonluo <[email protected]>

* update the config yaml file

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#8617 created/updated

* Changeset file for PR opensearch-project#8617 created/updated

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
@yubonluo @opensearch-changeset-bot @Qxisylolo
[Workspace] Update default workspace permission and users config supp…
fca95e4 
…ort wildcard (opensearch-project#8617)

* Update default workspace permission and support wildcard

Signed-off-by: yubonluo <[email protected]>

* update the config yaml file

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#8617 created/updated

* Changeset file for PR opensearch-project#8617 created/updated

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@Hailong-am Hailong-am Hailong-am approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yubonluo @SuZhou-Joe @Hailong-am