Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update content and styling of use case getting started cards #8614

Merged

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Oct 16, 2024

Description

Updates getting started cards:

  • Updates quantity to avoid having more than will fit on a page
  • Updates content to be consistent
  • Updates visual design to be consistent + use new styling

Callouts:

  • This requires an oui update for new icons so please hold off on merging until the next oui bump.
  • This intentionally tries to use OuiCards as they are today as we haven't designed a getting started component. All changes are only for getting started card use cases, so other cards aren't impact. I did override some oui styles as that seemed like the simplest option until we're able to create a dedicated component.

Issues Resolved

N/A

Screenshot

essentials
image

search
image

all
image

observability (updated in separate pr but including here for completion)
image

security analytics (updated in separate pr but including here for completion)
image

Testing the changes

Tested locally and reviewed by ux. Updated tests that existed, but some of these don't have snapshot tests in place. Can create if desired.

Changelog

  • fix: Update content and styling of use case getting started cards

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@virajsanghvi virajsanghvi added backport 2.x look & feel Look and Feel Improvements v2.18.0 labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (5c8b2e3) to head (03ae010).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/usecase_overview/search_use_case_setup.tsx 28.57% 5 Missing ⚠️
...ic/components/use_case_overview/setup_overview.tsx 0.00% 5 Missing ⚠️
...cation/components/sample_data/sample_data_card.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8614      +/-   ##
==========================================
- Coverage   60.94%   60.93%   -0.01%     
==========================================
  Files        3790     3790              
  Lines       90306    90315       +9     
  Branches    14154    14154              
==========================================
- Hits        55034    55033       -1     
- Misses      31815    31825      +10     
  Partials     3457     3457              
Flag Coverage Δ
Linux_1 29.29% <6.66%> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <10.00%> (-0.01%) ⬇️
Linux_4 29.90% <20.00%> (-0.01%) ⬇️
Windows_1 29.30% <6.66%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <10.00%> (-0.01%) ⬇️
Windows_4 29.90% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajsanghvi
Copy link
Collaborator Author

Putting this out for review and approvals, but please don't merge if it has approvals (want an oui bump first so icons show up)

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@virajsanghvi virajsanghvi merged commit 95b0a58 into opensearch-project:main Oct 18, 2024
69 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
)

* fix: Update content and styling of use case getting started cards

Signed-off-by: Viraj Sanghvi <[email protected]>

* Changeset file for PR #8614 created/updated

* update tests

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 95b0a58)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi pushed a commit that referenced this pull request Oct 18, 2024
) (#8644)

* fix: Update content and styling of use case getting started cards



* Changeset file for PR #8614 created/updated

* update tests



---------



(cherry picked from commit 95b0a58)

Signed-off-by: Viraj Sanghvi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
…ensearch-project#8614)

* fix: Update content and styling of use case getting started cards

Signed-off-by: Viraj Sanghvi <[email protected]>

* Changeset file for PR opensearch-project#8614 created/updated

* update tests

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…ensearch-project#8614)

* fix: Update content and styling of use case getting started cards

Signed-off-by: Viraj Sanghvi <[email protected]>

* Changeset file for PR opensearch-project#8614 created/updated

* update tests

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…ensearch-project#8614)

* fix: Update content and styling of use case getting started cards

Signed-off-by: Viraj Sanghvi <[email protected]>

* Changeset file for PR opensearch-project#8614 created/updated

* update tests

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants