Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Show add collaborators modal until collaborators added #8574

Merged

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Oct 12, 2024

Description

This PR is for updating a UX behavior when adding collaborators. The add collaborators modal will be displayed until collaborators added. The "Add collaborators" button will become disabled & loading state during the updating API call.

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and go to an existing workspace setting page
  • Click "Collaborators" tab
  • Click "Add Collaborators" button
  • Click "Add users" button in the dropdown
  • Enter user id and click "Add Collaborators" button, the "Add Collaborators" button should be disabled & loading state

Changelog

  • feat: [Workspace]Show add collaborators modal until collaborators added

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (9cad0a3) to head (2c17beb).
Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8574   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3777     3777           
  Lines       89843    89847    +4     
  Branches    14083    14083           
=======================================
+ Hits        54736    54740    +4     
  Misses      31672    31672           
  Partials     3435     3435           
Flag Coverage Δ
Linux_1 29.13% <100.00%> (+<0.01%) ⬆️
Linux_2 56.28% <ø> (ø)
Linux_3 37.81% <ø> (ø)
Linux_4 29.95% <ø> (ø)
Windows_1 29.15% <100.00%> (+<0.01%) ⬆️
Windows_2 56.23% <ø> (ø)
Windows_3 37.81% <ø> (+<0.01%) ⬆️
Windows_4 29.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit 8332e09 into opensearch-project:main Oct 14, 2024
67 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 14, 2024
)

* Show add collaborators modal until update success

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #8574 created/updated

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8332e09)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 14, 2024
) (#8578)

* Show add collaborators modal until update success



* Changeset file for PR #8574 created/updated

---------



(cherry picked from commit 8332e09)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…ensearch-project#8574)

* Show add collaborators modal until update success

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR opensearch-project#8574 created/updated

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…ensearch-project#8574)

* Show add collaborators modal until update success

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR opensearch-project#8574 created/updated

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants