-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Show add collaborators modal until collaborators added #8574
Merged
Hailong-am
merged 4 commits into
opensearch-project:main
from
wanglam:add-loading-to-collaborators-modal
Oct 14, 2024
Merged
[Workspace]Show add collaborators modal until collaborators added #8574
Hailong-am
merged 4 commits into
opensearch-project:main
from
wanglam:add-loading-to-collaborators-modal
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8574 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 3777 3777
Lines 89843 89847 +4
Branches 14083 14083
=======================================
+ Hits 54736 54740 +4
Misses 31672 31672
Partials 3435 3435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 12, 2024 09:39
SuZhou-Joe
approved these changes
Oct 12, 2024
Hailong-am
approved these changes
Oct 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
) * Show add collaborators modal until update success Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8574 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8332e09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 14, 2024
) (#8578) * Show add collaborators modal until update success * Changeset file for PR #8574 created/updated --------- (cherry picked from commit 8332e09) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…ensearch-project#8574) * Show add collaborators modal until update success Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR opensearch-project#8574 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…ensearch-project#8574) * Show add collaborators modal until update success Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR opensearch-project#8574 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for updating a UX behavior when adding collaborators. The add collaborators modal will be displayed until collaborators added. The "Add collaborators" button will become disabled & loading state during the updating API call.
Screenshot
Testing the changes
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration