Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add discover summary error info and button click logic enhancement #8568

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c4049eb from #8352.

…8352)

* Add discover summary error info and button click logic enhancement

Signed-off-by: Liyun Xiu <[email protected]>

* add changelog

Signed-off-by: Liyun Xiu <[email protected]>

* Address comments

Signed-off-by: Liyun Xiu <[email protected]>

---------

Signed-off-by: Liyun Xiu <[email protected]>
(cherry picked from commit c4049eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.03%. Comparing base (4000357) to head (b0c2e7a).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...c/query_assist/components/query_assist_summary.tsx 83.33% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8568   +/-   ##
=======================================
  Coverage   61.03%   61.03%           
=======================================
  Files        3770     3770           
  Lines       89581    89588    +7     
  Branches    14018    14022    +4     
=======================================
+ Hits        54673    54678    +5     
  Misses      31503    31503           
- Partials     3405     3407    +2     
Flag Coverage Δ
Linux_1 29.06% <ø> (ø)
Linux_2 56.41% <ø> (ø)
Linux_3 37.82% <ø> (ø)
Linux_4 30.07% <83.33%> (+<0.01%) ⬆️
Windows_1 29.07% <ø> (ø)
Windows_2 56.37% <ø> (ø)
Windows_3 37.83% <ø> (+<0.01%) ⬆️
Windows_4 30.07% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 9365ad6 into 2.x Oct 12, 2024
71 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-8352-to-2.x branch October 12, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset repeat-contributor v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants