Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x] Implement correct normalization of locales in i18n (#8535) #8561

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[Manual backport 2.x] Implement correct normalization of locales in i18n (#8535) #8561

merged 1 commit into from
Oct 11, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Cherry picked commit 2b149d2 from #8535

@AMoo-Miki
Implement correct normalization of locales in i18n (opensearch-projec…
bb279a6 
…t#8535)

* Implement correct normalization of locales in i18n

Also:
* Stop examining the fragment identifier for possible locale overrides

Signed-off-by: Miki <[email protected]>

* Update relative formats and plural rules for certain locales

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>

(cherry picked from commit 2b149d2)
Signed-off-by: Miki <[email protected]>
@AMoo-Miki AMoo-Miki added i18n Internationalization related Issues and PRs v2.18.0 labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.03%. Comparing base (9434dc2) to head (bb279a6).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
packages/osd-i18n/src/loader.ts 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8561   +/-   ##
=======================================
  Coverage   61.02%   61.03%           
=======================================
  Files        3771     3770    -1     
  Lines       89566    89579   +13     
  Branches    14017    14015    -2     
=======================================
+ Hits        54662    54671    +9     
- Misses      31496    31499    +3     
- Partials     3408     3409    +1
Flag Coverage Δ
Linux_1 29.06% <68.00%> (+0.03%) ⬆️
Linux_2 56.41% <84.90%> (-0.01%) ⬇️
Linux_3 37.82% <68.00%> (+0.04%) ⬆️
Linux_4 30.07% <70.37%> (+0.03%) ⬆️
Windows_1 29.07% <68.00%> (+0.03%) ⬆️
Windows_2 56.37% <84.90%> (-0.01%) ⬇️
Windows_3 37.82% <68.00%> (+0.04%) ⬆️
Windows_4 30.07% <70.37%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki changed the title Implement correct normalization of locales in i18n (#8535) [Manual backport 2.x] Implement correct normalization of locales in i18n (#8535) Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@AMoo-Miki AMoo-Miki merged commit 68c32e0 into opensearch-project:2.x Oct 11, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
failed changeset i18n Internationalization related Issues and PRs v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMoo-Miki @virajsanghvi @ananzh