[workspace]fix the workspace selector jump that occurs when hovering and clicking. #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 10, 2024
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
SuZhou-Joe
reviewed
Oct 11, 2024
src/plugins/workspace/public/components/workspace_selector/workspace_selector.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
feat/workspace-selector-jumps-on-hover
branch
from
0f6c3fe to
26ede1d
Compare
SuZhou-Joe
previously approved these changes
Oct 11, 2024
SuZhou-Joe
approved these changes
Oct 11, 2024
Hailong-am
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8541 +/- ##
==========================================
+ Coverage 60.93% 60.95% +0.01%
==========================================
Files 3769 3776 +7
Lines 89506 89638 +132
Branches 14012 14045 +33
==========================================
+ Hits 54539 54637 +98
- Misses 31557 31588 +31
- Partials 3410 3413 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The animation is the default behavior of a clickable OuiPanel, instead of override the styles from component library, maybe we shouldn't use |
ruanyl
approved these changes
Oct 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
…and clicking. (#8541) * fix/workspace-selector-jumps-on-hover, fix hover jumping Signed-off-by: Qxisylolo <[email protected]> * feat/workspace-selector-jumps-on-hover, change classname Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #8541 created/updated * Changeset file for PR #8541 created/updated * Changeset file for PR #8541 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3252a10) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Oct 14, 2024
…and clicking. (#8541) (#8579) * fix/workspace-selector-jumps-on-hover, fix hover jumping * feat/workspace-selector-jumps-on-hover, change classname * Changeset file for PR #8541 created/updated * Changeset file for PR #8541 created/updated * Changeset file for PR #8541 created/updated --------- (cherry picked from commit 3252a10) Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…and clicking. (opensearch-project#8541) * fix/workspace-selector-jumps-on-hover, fix hover jumping Signed-off-by: Qxisylolo <[email protected]> * feat/workspace-selector-jumps-on-hover, change classname Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR opensearch-project#8541 created/updated * Changeset file for PR opensearch-project#8541 created/updated * Changeset file for PR opensearch-project#8541 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…and clicking. (opensearch-project#8541) * fix/workspace-selector-jumps-on-hover, fix hover jumping Signed-off-by: Qxisylolo <[email protected]> * feat/workspace-selector-jumps-on-hover, change classname Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR opensearch-project#8541 created/updated * Changeset file for PR opensearch-project#8541 created/updated * Changeset file for PR opensearch-project#8541 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the workspace selector jump that occurs when hovering and clicking.
Screenshot
Before:
2024-10-10.13.56.10.mov
After:
2024-10-10.13.56.34.mov
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration