Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Switch OSD Optimizer to rely on file hashes instead of mtimes #8532

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0609ecf from #8472.

* Hotswap getMtimes to compute sha1 hashes

Signed-off-by: Simeon Widdis <[email protected]>

* Rename all the things

Signed-off-by: Simeon Widdis <[email protected]>

* Changeset file for PR #8472 created/updated

---------

Signed-off-by: Simeon Widdis <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 0609ecf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (effd6d5) to head (25ecf65).
Report is 59 commits behind head on 2.x.

Files with missing lines Patch % Lines
packages/osd-optimizer/src/optimizer/cache_keys.ts 20.00% 4 Missing ⚠️
packages/osd-optimizer/src/optimizer/get_hashes.ts 50.00% 2 Missing ⚠️
packages/osd-optimizer/src/common/bundle.ts 0.00% 1 Missing ⚠️
packages/osd-optimizer/src/node/cache.ts 66.66% 1 Missing ⚠️
...ckages/osd-optimizer/src/optimizer/bundle_cache.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8532   +/-   ##
=======================================
  Coverage   61.02%   61.02%           
=======================================
  Files        3768     3768           
  Lines       89520    89521    +1     
  Branches    14006    14006           
=======================================
+ Hits        54629    54630    +1     
  Misses      31487    31487           
  Partials     3404     3404           
Flag Coverage Δ
Linux_1 29.01% <44.44%> (+<0.01%) ⬆️
Linux_2 56.39% <22.22%> (+<0.01%) ⬆️
Linux_3 37.78% <ø> (ø)
Linux_4 30.03% <22.22%> (+<0.01%) ⬆️
Windows_1 29.02% <44.44%> (+<0.01%) ⬆️
Windows_2 56.35% <22.22%> (+<0.01%) ⬆️
Windows_3 37.78% <ø> (ø)
Windows_4 30.03% <22.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit d21f8a6 into 2.x Oct 23, 2024
68 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-8472-to-2.x branch October 23, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset infra repeat-contributor v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants