Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hiding the TSVB axis for time series #8504

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Allow hiding the TSVB axis for time series #8504

merged 2 commits into from
Oct 10, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Allow hiding the TSVB axis for time series

Also:

  • Compress non-OUI input fields in TSVB visualizations
  • Allow setting scale of each axis for TSVB time series

Issues Resolved

Fixes #1929

Screenshot

Before After
Before After

Changelog

  • feat: Allow hiding the TSVB axis for time series visualizations
  • fix: Compress non-OUI input fields in TSVB visualizations
  • feat: Allow setting scale of each axis for TSVB time series

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki
Allow hiding the TSVB axis for time series
4feaed1 
Also:
* Compress non-OUI input fields
* Allow setting scale of each axis for time series

Signed-off-by: Miki <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (e077644) to head (2b9cf2a).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...lication/components/vis_types/timeseries/config.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8504      +/-   ##
==========================================
+ Coverage   60.93%   60.94%   +0.01%     
==========================================
  Files        3760     3766       +6     
  Lines       89301    89368      +67     
  Branches    13969    13978       +9     
==========================================
+ Hits        54412    54469      +57     
- Misses      31493    31501       +8     
- Partials     3396     3398       +2
Flag Coverage Δ
Linux_1 28.96% <25.00%> (+0.05%) ⬆️
Linux_2 56.30% <ø> (ø)
Linux_3 37.76% <ø> (ø)
Linux_4 29.93% <ø> (-0.01%) ⬇️
Windows_1 28.98% <25.00%> (+0.05%) ⬆️
Windows_2 56.25% <ø> (ø)
Windows_3 37.76% <ø> (ø)
Windows_4 29.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgcreative
Copy link
Member

LGTM! 🚀

@AMoo-Miki AMoo-Miki merged commit 2ffb11f into opensearch-project:main Oct 10, 2024
73 of 74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@github-actions @opensearch-changeset-bot
Allow hiding the TSVB axis for time series (#8504)
0cbfbe6 
* Allow hiding the TSVB axis for time series

Also:
* Compress non-OUI input fields
* Allow setting scale of each axis for time series

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8504 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2ffb11f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2024
Merged
ananzh pushed a commit that referenced this pull request Oct 11, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Allow hiding the TSVB axis for time series (#8504) (#8547)
81a96a4 
* Allow hiding the TSVB axis for time series
* Compress non-OUI input fields
* Allow setting scale of each axis for time series

---------



(cherry picked from commit 2ffb11f)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
@AMoo-Miki @opensearch-changeset-bot @Qxisylolo
Allow hiding the TSVB axis for time series (opensearch-project#8504)
c2c179d 
* Allow hiding the TSVB axis for time series

Also:
* Compress non-OUI input fields
* Allow setting scale of each axis for time series

Signed-off-by: Miki <[email protected]>

* Changeset file for PR opensearch-project#8504 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor tsvb v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Enabling separate axis for a TSVB Time Series graph overrides Axis Scale setting in Panel Options
4 participants
@AMoo-Miki @kgcreative @virajsanghvi @ashwin-pc