Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: update border style when new left nav expanded #8489

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Oct 4, 2024

Description

Remove the shadow style and only show the border when left nav expanded.

Issues Resolved

Screenshot

Theme v9 light mode

image

Theme v9 dark mode

image

Testing the changes

Changelog

  • feat: update border style when new left nav expanded

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe added backport 2.x look & feel Look and Feel Improvements labels Oct 4, 2024
@SuZhou-Joe SuZhou-Joe marked this pull request as draft October 4, 2024 08:00
Signed-off-by: SuZhou-Joe <[email protected]>
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (8fa7ff4) to head (6663fd4).
Report is 192 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8489      +/-   ##
==========================================
- Coverage   60.93%   60.93%   -0.01%     
==========================================
  Files        3760     3760              
  Lines       89310    89301       -9     
  Branches    13970    13969       -1     
==========================================
- Hits        54423    54414       -9     
  Misses      31492    31492              
  Partials     3395     3395              
Flag Coverage Δ
Linux_1 28.90% <ø> (-0.01%) ⬇️
Linux_2 56.30% <ø> (ø)
Linux_3 37.76% <ø> (ø)
Linux_4 29.93% <ø> (ø)
Windows_1 28.92% <ø> (-0.01%) ⬇️
Windows_2 56.25% <ø> (ø)
Windows_3 37.76% <ø> (ø)
Windows_4 29.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review October 4, 2024 14:52
@SuZhou-Joe SuZhou-Joe merged commit 2f90def into opensearch-project:main Oct 7, 2024
70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2024
* feat: update border style

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8489 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update border color

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2f90def)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Oct 7, 2024
…) (#8509)

* feat: update border style



* Changeset file for PR #8489 created/updated

* feat: update



* feat: update border color



---------



(cherry picked from commit 2f90def)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants