Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Discover] Support data connections and multi-select table in dataset picker #8438

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[Backport 2.x] [Discover] Support data connections and multi-select table in dataset picker #8438

merged 1 commit into from
Oct 2, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fd31398 from #8255.

@github-actions @opensearch-changeset-bot
[Discover] Support data connections and multi-select table in dataset…
c4e5cae 
… picker (#8255)

* initial implementation of cloud watch data set type

Signed-off-by: Joshua Li <[email protected]>

* wip-- support selecting multiple datasets

Signed-off-by: Joshua Li <[email protected]>

* Revert "wip-- support selecting multiple datasets"

This reverts commit 4977cc9.

Signed-off-by: Joshua Li <[email protected]>

* add multi-select dataset table

Signed-off-by: Joshua Li <[email protected]>

* add token based pagination in dataset table

Signed-off-by: Joshua Li <[email protected]>

* display data connection in dataset title

Signed-off-by: Joshua Li <[email protected]>

* avoid overlap of dataset title and language selector

Signed-off-by: Joshua Li <[email protected]>

* Revert "avoid overlap of dataset title and language selector"

This reverts commit 87d599d.
Wait for #8204

Signed-off-by: Joshua Li <[email protected]>

* revert query enhancement changes for cloudwatch

Signed-off-by: Joshua Li <[email protected]>

* Changeset file for PR #8255 created/updated

* Revert "revert query enhancement changes for cloudwatch"

This reverts commit 5eb065a.

Signed-off-by: Joshua Li <[email protected]>

* address comments

Signed-off-by: Joshua Li <[email protected]>

* revert query enhancement changes for cloudwatch

Signed-off-by: Joshua Li <[email protected]>

* address comments

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit fd31398)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports seasoned-contributor discover-next v2.18.0 labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (65f213b) to head (c4e5cae).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ta/public/ui/dataset_selector/dataset_explorer.tsx 0.00% 21 Missing ⚠️
.../data/public/ui/dataset_selector/dataset_table.tsx 86.66% 1 Missing and 3 partials ⚠️
...ry/query_string/dataset_service/dataset_service.ts 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8438   +/-   ##
=======================================
  Coverage   61.02%   61.02%           
=======================================
  Files        3755     3756    +1     
  Lines       89208    89248   +40     
  Branches    13938    13947    +9     
=======================================
+ Hits        54441    54466   +25     
- Misses      31389    31399   +10     
- Partials     3378     3383    +5
Flag Coverage Δ
Linux_1 28.88% <0.00%> (-0.01%) ⬇️
Linux_2 56.46% <ø> (ø)
Linux_3 37.81% <50.00%> (+0.02%) ⬆️
Linux_4 30.08% <0.00%> (-0.01%) ⬇️
Windows_1 28.89% <0.00%> (-0.01%) ⬇️
Windows_2 56.42% <ø> (ø)
Windows_3 37.81% <50.00%> (+0.02%) ⬆️
Windows_4 30.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit d61dcea into 2.x Oct 2, 2024
68 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-8255-to-2.x branch October 2, 2024 08:13
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @SuZhou-Joe
[Discover] Support data connections and multi-select table in dataset…
fae58c6 
… picker (opensearch-project#8255) (opensearch-project#8438)

* initial implementation of cloud watch data set type



* wip-- support selecting multiple datasets



* Revert "wip-- support selecting multiple datasets"

This reverts commit 4977cc9.



* add multi-select dataset table



* add token based pagination in dataset table



* display data connection in dataset title



* avoid overlap of dataset title and language selector



* Revert "avoid overlap of dataset title and language selector"

This reverts commit 87d599d.
Wait for opensearch-project#8204



* revert query enhancement changes for cloudwatch



* Changeset file for PR opensearch-project#8255 created/updated

* Revert "revert query enhancement changes for cloudwatch"

This reverts commit 5eb065a.



* address comments



* revert query enhancement changes for cloudwatch



* address comments



---------



(cherry picked from commit fd31398)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset seasoned-contributor v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavilla @ashwin-pc