Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky IndexPatternSelect test in data plugin #8429

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix flaky IndexPatternSelect test in data plugin #8429

merged 1 commit into from
Oct 2, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Fix flaky IndexPatternSelect test in data plugin

Changelog

  • test: Fix flaky IndexPatternSelect test in data plugin

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Oct 1, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8429 created/updated
2e9bbd9
@AMoo-Miki AMoo-Miki force-pushed the fix-flaky-data-ips-test branch from 2e9bbd9 to 62e4909 Compare October 1, 2024 23:57
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (daa59de) to head (62e4909).
Report is 44 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8429   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3756     3756           
  Lines       89185    89185           
  Branches    13941    13941           
=======================================
  Hits        54337    54337           
  Misses      31467    31467           
  Partials     3381     3381
Flag Coverage Δ
Linux_1 28.85% <ø> (ø)
Linux_2 56.35% <ø> (ø)
Linux_3 37.73% <ø> (-0.01%) ⬇️
Linux_4 29.96% <ø> (ø)
Windows_1 28.87% <ø> (ø)
Windows_2 56.30% <ø> (ø)
Windows_3 37.74% <ø> (ø)
Windows_4 29.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hailong-am
Hailong-am approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@AMoo-Miki AMoo-Miki merged commit 774909e into opensearch-project:main Oct 2, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2024
@github-actions
Fix flaky IndexPatternSelect test in data plugin (#8429)
a38901e 
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 774909e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 6, 2024
Merged
kavilla pushed a commit that referenced this pull request Oct 24, 2024
@opensearch-trigger-bot @github-actions
Fix flaky IndexPatternSelect test in data plugin (#8429) (#8506)
ac7bf02 
(cherry picked from commit 774909e)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMoo-Miki @SuZhou-Joe @Hailong-am