[Workspace] feat: support use case populate for workspace create and list page #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
opensearch-changeset-bot bot
added a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Oct 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8422 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3758 3758
Lines 89305 89326 +21
Branches 13972 13974 +2
=======================================
+ Hits 54439 54453 +14
- Misses 31478 31481 +3
- Partials 3388 3392 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
previously approved these changes
Oct 2, 2024
Comment on lines
+28
to
+34
| <Router> | ||
| <Switch> | ||
| <Route> | ||
| <WorkspaceCreatorApp {...props} /> | ||
| </Route> | ||
| </Switch> | ||
| </Router> |
There was a problem hiding this comment.
why do we need add router?
There was a problem hiding this comment.
I have the same concern that is the HashRouter here necessary?
There was a problem hiding this comment.
Yes, we need hashRouter to wrap switch and route.
| @@ -23,6 +23,12 @@ export const navigateToWorkspaceDetail = ( | |||
| ); | |||
| }; | |||
|
|
|||
| export const navigateToWorkspaceListWithUseCase = ({ application }: Core, useCaseTitle: string) => { | |||
| const url = application.getUrlForApp(WORKSPACE_LIST_APP_ID, { absolute: true }); | |||
| const search = `/?useCase=${useCaseTitle}`; | |||
There was a problem hiding this comment.
can we use hash, so that router change is not needed? similar with workspace detail page
There was a problem hiding this comment.
Updated. This may just be a boilerplate for now, it actually depends on how @yubonluo uses later.
There was a problem hiding this comment.
If necessary in the future, I will make some adjustments when integrating it to the homepage
SuZhou-Joe
reviewed
Oct 2, 2024
src/plugins/workspace/public/components/workspace_creator/workspace_creator.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Oct 2, 2024
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
SuZhou-Joe
approved these changes
Oct 3, 2024
SuZhou-Joe
approved these changes
Oct 3, 2024
Hailong-am
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
…list page (#8422) * feat: support use case populate for workspace create and list page Signed-off-by: tygao <[email protected]> * style: update data source column width Signed-off-by: tygao <[email protected]> * Changeset file for PR #8422 created/updated * update navigate function Signed-off-by: tygao <[email protected]> * test: add utils test Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 49cca7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 3, 2024
…list page (#8422) (#8462) * feat: support use case populate for workspace create and list page * style: update data source column width * Changeset file for PR #8422 created/updated * update navigate function * test: add utils test --------- (cherry picked from commit 49cca7b) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Testing the changes
Go to workspace create/list page and use useCase search, for example
http://localhost:6601/app/workspace_list#/?useCase=Security%20Analytics , then you could see security use case to be populated.
Changelog
Check List
yarn test:jestyarn test:jest_integration