-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18n checks to PR workflows #8411
Conversation
❌ Invalid PrefixInvalid description prefix. Found "maintenance". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8411 +/- ##
==========================================
- Coverage 60.93% 60.93% -0.01%
==========================================
Files 3760 3760
Lines 89310 89312 +2
Branches 13970 13971 +1
==========================================
- Hits 54423 54421 -2
- Misses 31492 31495 +3
- Partials 3395 3396 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@AMoo-Miki Tests where pass? |
Tests pass when no translation files are available. I removed this ignoring in the PR that split stuff and kept them separate to not block the workflows. This or that PR will be the last one of i18n that we merge for everything to kick in.
|
Also: * Add help text and description to `i18n-check` * Fix malformed translations Signed-off-by: Miki <[email protected]>
17b1951
to
2450bfc
Compare
3adb588
to
f4ed90a
Compare
fix, | ||
}, | ||
log | ||
), | ||
{ exitOnError: true } | ||
{ exitOnError: false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems changed the existing behavior, is it by intention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. If true
, it exits at the first error. When false, it logs them all and then finally throws.
While "checking" we would rather have all of the problems shown to us, as opposed to just the first problem.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8411-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 428a7c2c9165b43c0343e293acd143e0bdac58b4
# Push it to GitHub
git push --set-upstream origin backport/backport-8411-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8411-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 428a7c2c9165b43c0343e293acd143e0bdac58b4
# Push it to GitHub
git push --set-upstream origin backport/backport-8411-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* Ignore missing `formats` while checking locale files Also: * Add help text and description to `i18n-check` * Fix malformed translations Signed-off-by: Miki <[email protected]> * Add i18n checks to PR workflows Signed-off-by: Miki <[email protected]> * Changeset file for PR opensearch-project#8411 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 428a7c2) Signed-off-by: Miki <[email protected]>
* Ignore missing `formats` while checking locale files Also: * Add help text and description to `i18n-check` * Fix malformed translations * Add i18n checks to PR workflows * Changeset file for PR #8411 created/updated --------- (cherry picked from commit 428a7c2) Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
formats
while checking locale filesi18n-check
Changelog
formats
while checking locale filesi18n-check
Check List
yarn test:jest
yarn test:jest_integration