Fix dynamic uses of i18n and correct unprefixed i18n identifiers in queryEnhancements plugin #8397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueryEnhancements plugin Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8397 +/- ##
==========================================
- Coverage 60.92% 60.92% -0.01%
==========================================
Files 3750 3750
Lines 89103 89103
Branches 13925 13925
==========================================
- Hits 54285 54283 -2
- Misses 31442 31443 +1
- Partials 3376 3377 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM, thanks for the changes |
ruanyl
approved these changes
Oct 2, 2024
ZilongX
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ueryEnhancements plugin (#8397) * Fix dynamic uses of i18n and correct unprefixed i18n identifiers in queryEnhancements plugin Signed-off-by: Miki <[email protected]> * Changeset file for PR #8397 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6f712e2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ueryEnhancements plugin (#8397) (#8471) * Fix dynamic uses of i18n and correct unprefixed i18n identifiers in queryEnhancements plugin * Changeset file for PR #8397 created/updated --------- (cherry picked from commit 6f712e2) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix dynamic uses of i18n and correct unprefixed i18n identifiers in queryEnhancements plugin
Changelog
Check List
yarn test:jestyarn test:jest_integration