Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin #8394

Merged
merged 2 commits into from
Oct 4, 2024

Changeset file for PR #8394 created/updated

1d2f7eb
Select commit
Loading
Failed to load commit list.
Merged

Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin #8394

Changeset file for PR #8394 created/updated
1d2f7eb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 1, 2024 in 1s

60.92% (+0.00%) compared to a663a84

View this Pull Request on Codecov

60.92% (+0.00%) compared to a663a84

Details

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (a663a84) to head (1d2f7eb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...source_management/public/components/breadcrumbs.ts 0.00% 0 Missing and 3 partials ⚠️
...c/components/edit_data_source/edit_data_source.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8394   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3750     3752    +2     
  Lines       89103    89135   +32     
  Branches    13925    13932    +7     
=======================================
+ Hits        54285    54306   +21     
- Misses      31442    31451    +9     
- Partials     3376     3378    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov