Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation]feat: remember state when expand / collapse left nav #8389

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a663a84 from #8286.

* feat: remember state

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8286 created/updated

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a663a84)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.00%. Comparing base (7c011ad) to head (c5efc1f).
Report is 144 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8389   +/-   ##
=======================================
  Coverage   61.00%   61.00%           
=======================================
  Files        3748     3748           
  Lines       89087    89092    +5     
  Branches    13909    13911    +2     
=======================================
+ Hits        54346    54353    +7     
+ Misses      31368    31367    -1     
+ Partials     3373     3372    -1     
Flag Coverage Δ
Linux_1 28.83% <0.00%> (-0.01%) ⬇️
Linux_2 56.47% <100.00%> (+<0.01%) ⬆️
Linux_3 37.76% <0.00%> (+<0.01%) ⬆️
Linux_4 30.08% <0.00%> (-0.01%) ⬇️
Windows_1 28.84% <0.00%> (-0.01%) ⬇️
Windows_2 56.42% <100.00%> (+<0.01%) ⬆️
Windows_3 37.76% <0.00%> (-0.01%) ⬇️
Windows_4 30.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit ea5f614 into 2.x Oct 1, 2024
69 of 72 checks passed
@github-actions github-actions bot deleted the backport/backport-8286-to-2.x branch October 1, 2024 03:25
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…nsearch-project#8286) (opensearch-project#8389)

* feat: remember state



* Changeset file for PR opensearch-project#8286 created/updated

* feat: optimize code



* feat: update



---------



(cherry picked from commit a663a84)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@SuZhou-Joe SuZhou-Joe added v2.18.0 and removed 2.17.1 labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants