Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace][Bug]Fix workspace detail page issues #8317

Merged

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Sep 24, 2024

Description

Fix workspace detail page issues:

  • Add a modal warning if user navigates away without saving changes in any of the tabs
  • Add “Set as default" button
  • Add a mock for the header when the workspace is set to default
  • Right align the column with Related connections number
  • Delete workspace overview link from detail panel
  • Add view workspace button

Issues Resolved

Screenshot

Add a modal warning if user navigates away without saving changes in any of the tabs
Add “Set as default" button and Add a mock for the header when the workspace is set to default

2024-09-25.11.38.36.mp4

Right align the column with Related connections number:
image

Delete workspace overview link from detail panel and Add view workspace button
image

Testing the changes

Changelog

  • fix: Fix workspace detail page issues

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Sep 27, 2024
SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 30, 2024
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 948b3d6 into opensearch-project:main Sep 30, 2024
65 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
* Fix workspace detail page issues

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #8317 created/updated

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimzize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* add callback function to onLeave

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* navigate to workspace overview page in other tab

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* update assocation toast

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* add loding state for set default workspace button

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the comment

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 948b3d6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 30, 2024
* Fix workspace detail page issues



* Changeset file for PR #8317 created/updated

* optimize the code



* optimzize the code



* optimize the code



* add callback function to onLeave



* optimize the code



* optimize the code



* navigate to workspace overview page in other tab



* optimize the code



* optimize the code



* optimize the code



* optimize the code



* optimize the code



* update assocation toast



* optimize the code



* add loding state for set default workspace button



* optimize the code



* optimize the comment



---------



(cherry picked from commit 948b3d6)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…8317) (opensearch-project#8387)

* Fix workspace detail page issues



* Changeset file for PR opensearch-project#8317 created/updated

* optimize the code



* optimzize the code



* optimize the code



* add callback function to onLeave



* optimize the code



* optimize the code



* navigate to workspace overview page in other tab



* optimize the code



* optimize the code



* optimize the code



* optimize the code



* optimize the code



* update assocation toast



* optimize the code



* add loding state for set default workspace button



* optimize the code



* optimize the comment



---------



(cherry picked from commit 948b3d6)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants