Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]fix: add xxl and xxxl for left nav responsiveness #8289

Merged
merged 3 commits into from
Sep 24, 2024
Merged

[navigation]fix: add xxl and xxxl for left nav responsiveness #8289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80b9951
fix: add xxl and xxxl
SuZhou-Joe Sep 23, 2024
88389b2
feat: update
SuZhou-Joe Sep 23, 2024
a09c1ca
feat: update snapshot
SuZhou-Joe Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
EuiSpacer,
EuiHideFor,
EuiFlyoutProps,
EuiShowFor,
} from '@elastic/eui';
import { i18n } from '@osd/i18n';
import React, { useMemo } from 'react';
Expand Down Expand Up @@ -368,7 +369,7 @@ export function CollapsibleNavGroupEnabled({
return (
<>
<EuiHideFor sizes={['xs', 's', 'm']}>{rendeLeftNav()}</EuiHideFor>
<EuiHideFor sizes={['xl', 'l']}>
<EuiShowFor sizes={['xs', 's', 'm']}>
{isNavOpen
? rendeLeftNav({
type: 'overlay',
Expand All @@ -378,7 +379,7 @@ export function CollapsibleNavGroupEnabled({
ownFocus: true,
})
: null}
</EuiHideFor>
</EuiShowFor>
</>
);
}
3 changes: 2 additions & 1 deletion src/core/public/chrome/ui/header/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ export function Header({
})}
{renderNavToggleWithExtraProps({
flush: 'both',
className: 'navToggleInSmallScreen eui-hideFor--xl eui-hideFor--l',
className:
'navToggleInSmallScreen eui-hideFor--xl eui-hideFor--l eui-hideFor--xxl eui-hideFor--xxxl',
isSmallScreen: true,
})}
</>
Expand Down
Loading