-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace]Fix/the UI of workspace list table #8219
[workspace]Fix/the UI of workspace list table #8219
Conversation
2e696d6
to
806654f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8219 +/- ##
==========================================
+ Coverage 60.86% 60.87% +0.01%
==========================================
Files 3808 3808
Lines 91209 91209
Branches 14410 14410
==========================================
+ Hits 55514 55528 +14
+ Misses 32154 32140 -14
Partials 3541 3541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
92c2b34
to
4886299
Compare
c378907
to
0f61a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there is a conflict now, you may need to address :)
return isDashboardAdmin ? ( | ||
<> | ||
<EuiButton color="danger" iconType="trash" onClick={onClick}> | ||
Delete {selection.length} {selection.length > 1 ? 'workspaces' : 'workspace'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add i18n for the text, take this as example:
<FormattedMessage
id="dataSourcesManagement.dataSourcesTable.dissociateSelectedDataSources"
defaultMessage="{selectionSize, plural, one {Remove # association} other {Remove # associations}}"
values={{ selectionSize: selectedDataSources.length }}
/>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments, already updated.
0f61a69
to
9bf0be9
Compare
{i18n.translate('workspace.list.page.delete.button.info', { | ||
defaultMessage: 'Delete {num} workspace{pluralSuffix, select, true {} other {s}}', | ||
values: { | ||
num: selection.length, | ||
pluralSuffix: selection.length === 1, | ||
}, | ||
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{i18n.translate('workspace.list.page.delete.button.info', { | |
defaultMessage: 'Delete {num} workspace{pluralSuffix, select, true {} other {s}}', | |
values: { | |
num: selection.length, | |
pluralSuffix: selection.length === 1, | |
}, | |
})} | |
{i18n.translate('workspace.list.page.delete.button.info', { | |
defaultMessage: | |
'{selectedCount, plural, one {Delete # workspace} other {Delete # workspaces}}', | |
values: { | |
selectedCount: selection.length, | |
}, | |
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! already updated.
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
7176e0f
to
f52af39
Compare
* fix/ fix the_UI_of_workspace_list Signed-off-by: Qxisylolo <[email protected]> * fix/ fix the_UI_of_workspace_list_mostly_done Signed-off-by: Qxisylolo <[email protected]> * fix/ fix the_UI_of_workspace_list_typo_mistake Signed-off-by: Qxisylolo <[email protected]> * fix/the-UI-of-workspace-list-table, delete owner filter Signed-off-by: Qxisylolo <[email protected]> * fix/the-UI-of-workspace-list-table, fix a small bug Signed-off-by: Qxisylolo <[email protected]> * resolve comments, add tests Signed-off-by: Qxisylolo <[email protected]> * solve conflicts, update tests Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #8219 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 9d21b81) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix/ fix the_UI_of_workspace_list * fix/ fix the_UI_of_workspace_list_mostly_done * fix/ fix the_UI_of_workspace_list_typo_mistake * fix/the-UI-of-workspace-list-table, delete owner filter * fix/the-UI-of-workspace-list-table, fix a small bug * resolve comments, add tests * solve conflicts, update tests * Changeset file for PR #8219 created/updated --------- (cherry picked from commit 9d21b81) Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Description
This pr fixes the style of workspace list table(addressing issues 217-227, and 232-233) by:
Screenshot
Changelog
Check List
yarn test:jest
yarn test:jest_integration