Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Dynamic Config] Fix bug when attempting dynamic config index creation #8192

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[Backport 2.x] [Dynamic Config] Fix bug when attempting dynamic config index creation #8192

merged 1 commit into from
Sep 13, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 678c644 from #8184.

@github-actions @opensearch-changeset-bot
[Dynamic Config] Fix bug when attempting dynamic config index creation (
799bd46 
#8184)

* Fix bug when attempting dynamic config index creation

Signed-off-by: Huy Nguyen <[email protected]>

* Changeset file for PR #8184 created/updated

---------

Signed-off-by: Huy Nguyen <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 678c644)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports seasoned-contributor labels Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.98%. Comparing base (24a919a) to head (799bd46).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...fig_store_client/opensearch_config_store_client.ts 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8192   +/-   ##
=======================================
  Coverage   63.97%   63.98%           
=======================================
  Files        3738     3738           
  Lines       88758    88784   +26     
  Branches    13804    13812    +8     
=======================================
+ Hits        56787    56811   +24     
- Misses      31374    31376    +2     
  Partials      597      597
Flag Coverage Δ
Linux_1 29.95% <6.66%> (-0.01%) ⬇️
Linux_2 58.95% <96.66%> (+0.03%) ⬆️
Linux_3 40.27% <6.66%> (-0.02%) ⬇️
Linux_4 31.47% <6.66%> (-0.02%) ⬇️
Windows_1 29.97% <6.66%> (-0.01%) ⬇️
Windows_2 58.89% <96.66%> (+0.03%) ⬆️
Windows_3 40.27% <6.66%> (+0.04%) ⬆️
Windows_4 31.47% <6.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit 4a06f52 into 2.x Sep 13, 2024
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyaboo huyaboo huyaboo approved these changes

@zhyuanqi zhyuanqi zhyuanqi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhyuanqi @huyaboo @BionIT