Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]fix: optimize the logic to detect current nav group #8189

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 13, 2024

Description

This PR is to fix the bug that:

  1. current nav group will be mapped to global system nav group even if user is in a workspace.
left+nav.mov
  1. current nav group will be mapped to a nav group even when user is out of a workspace.
image

Issues Resolved

Screenshot

1. current nav group will be mapped to global system nav group even if user is in a workspace.

20240913162710198.mp4

2. current nav group will be mapped to a nav group even when user is out of a workspace.

image

Testing the changes

Changelog

  • fix: current nav group will be mapped to global system nav group even if user is in a workspace.
  • fix: current nav group will be mapped to a nav group even when user is out of a workspace.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (8118024) to head (22d43f5).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8189   +/-   ##
=======================================
  Coverage   64.03%   64.03%           
=======================================
  Files        3740     3740           
  Lines       88580    88589    +9     
  Branches    13790    13794    +4     
=======================================
+ Hits        56720    56726    +6     
- Misses      31262    31265    +3     
  Partials      598      598           
Flag Coverage Δ
Linux_1 30.04% <0.00%> (-0.01%) ⬇️
Linux_2 58.80% <100.00%> (+<0.01%) ⬆️
Linux_3 40.38% <0.00%> (-0.01%) ⬇️
Linux_4 31.47% <0.00%> (-0.01%) ⬇️
Windows_1 30.05% <0.00%> (-0.01%) ⬇️
Windows_2 58.75% <100.00%> (+<0.01%) ⬆️
Windows_3 40.38% <0.00%> (-0.01%) ⬇️
Windows_4 31.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <[email protected]>
@ruanyl
Copy link
Member

ruanyl commented Sep 19, 2024

@SuZhou-Joe should this be tagged with 2.17.1 now?

@SuZhou-Joe SuZhou-Joe added 2.17.1 and removed v2.18.0 labels Sep 23, 2024
@SuZhou-Joe
Copy link
Member Author

@SuZhou-Joe should this be tagged with 2.17.1 now?

Yes, updated.

@ZilongX ZilongX merged commit 9a88bf5 into opensearch-project:main Sep 24, 2024
76 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
* fix: optimize the logic to detect current nav group

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8189 created/updated

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9a88bf5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 25, 2024
… (#8321)

* fix: optimize the logic to detect current nav group



* feat: optimize code



* Changeset file for PR #8189 created/updated

---------



(cherry picked from commit 9a88bf5)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Sep 25, 2024
…search-project#8189) (opensearch-project#8321)

* fix: optimize the logic to detect current nav group



* feat: optimize code



* Changeset file for PR opensearch-project#8189 created/updated

---------



(cherry picked from commit 9a88bf5)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants