[Discover] UI Updates to Dataset Configurator

[sejli]

Description

• Fixes blank row at bottom of Discover, thanks @ashwin-pc @AMoo-Miki for the change
• Fixes an issue where indexes were able to be selected with a placeholder time field, which would cause issues
• Disables time field selector in index pattern configurator if the index pattern already has a time field.

Issues Resolved

Screenshot

Testing the changes

Changelog

• fix: Fixes UI issues in Discover and data configurator

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (1f9da21) to head (542d89f).
Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/data/public/ui/dataset_selector/configurator.tsx	0.00%	14 Missing ⚠️
.../data_explorer/public/components/app_container.tsx	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8166      +/-   ##
==========================================
- Coverage   60.95%   60.94%   -0.01%     
==========================================
  Files        3758     3759       +1     
  Lines       89288    89330      +42     
  Branches    13970    13977       +7     
==========================================
+ Hits        54422    54441      +19     
- Misses      31478    31491      +13     
- Partials     3388     3398      +10     

Flag	Coverage Δ
Linux_1	28.92% <0.00%> (+0.02%)	⬆️
Linux_2	56.30% <ø> (-0.06%)	⬇️
Linux_3	37.78% <6.25%> (+<0.01%)	⬆️
Linux_4	29.93% <0.00%> (-0.02%)	⬇️
Windows_1	28.93% <0.00%> (+0.02%)	⬆️
Windows_2	56.25% <ø> (-0.06%)	⬇️
Windows_3	37.78% <6.25%> (-0.01%)	⬇️
Windows_4	29.93% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ashwin-pc]

Disables time field selector in index pattern configurator if the index pattern already has a time field.

The time field selector should be disabled no matter what for index patterns. So even if they have an index pattern where they have selected no time field, this should not let the user edit it.

[ashwin-pc]

Just lemme know if my functional logic makes sense.

[ashwin-pc]

The logic here reads wrong. Correct me if my understanding is wrong but shouldnt the logic be like this:

if(languageService.getLanguage(language)?.disableDatePicker) {
  return null
}

if(dataset.type === DEFAULT_DATA.SET_TYPES.INDEX_PATTERN) {
  return DisabledInput
} else {
  return Select
}

[ashwin-pc]

+1

[ashwin-pc]

lgtm! just a comment about the name of the config to ensure consistency. but if we wanted to do that we should do that as a fast follow and not block this pr.

also should we just with @opensearch-project/opensearch-ux . the language selector is below the timefield selection but the language will display or hide the the timefield selection so the language is shifting. should we consider a different order?

Yeah lets flip the order!

[joshuali925]

i think this is fine but it's better to separate them, since text can change (e.g. different translation, future UX wording update), and value should not change

[ashwin-pc]

+1

[ashwin-pc]

+1