Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport] [Backport 2.17] data source permission client wrapper error of not returning explicitly the saved object client functions #8128

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[Manual backport] [Backport 2.17] data source permission client wrapper error of not returning explicitly the saved object client functions #8128

merged 1 commit into from
Sep 11, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Sep 11, 2024

Description

Manual backport #8118

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ruanyl
fix: data source permission client wrapper error of not returning
1e46a86 
explicitly the saved object client functions

Signed-off-by: Yulong Ruan <[email protected]>

Changeset file for PR opensearch-project#8118 created/updated
@ruanyl ruanyl changed the title fix: data source permission client wrapper error of not returning explicitly the saved object client functions [Manual backport] backport/backport-8118-to-2.7 Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl ruanyl changed the title [Manual backport] backport/backport-8118-to-2.7 [Manual backport] [Backport 2.17] data source permission client wrapper error of not returning explicitly the saved object client functions Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl ruanyl added the v2.17.0 label Sep 11, 2024
@ruanyl ruanyl added the multiple datasource multiple datasource project label Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.92%. Comparing base (5ce8e5d) to head (1e46a86).
Report is 2 commits behind head on 2.17.

Additional details and impacted files 
@@           Coverage Diff           @@
##             2.17    #8128   +/-   ##
=======================================
  Coverage   63.91%   63.92%           
=======================================
  Files        3737     3737           
  Lines       88679    88679           
  Branches    13779    13779           
=======================================
+ Hits        56683    56684    +1     
+ Misses      31403    31402    -1     
  Partials      593      593
Flag Coverage Δ
Linux_1 29.97% <ø> (ø)
Linux_2 58.91% <ø> (ø)
Linux_3 40.28% <ø> (+<0.01%) ⬆️
Linux_4 31.31% <ø> (ø)
Windows_1 29.98% <ø> (ø)
Windows_2 58.86% <ø> (ø)
Windows_3 40.28% <ø> (ø)
Windows_4 31.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 39be6a9 into opensearch-project:2.17 Sep 11, 2024
67 of 70 checks passed
@ruanyl ruanyl mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@zhongnansu zhongnansu zhongnansu approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
failed changeset multiple datasource multiple datasource project v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruanyl @SuZhou-Joe @zhongnansu @ZilongX