Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport] [Backport 2.x] data source permission client wrapper error of not returning explicitly the saved object client functions #8127

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Sep 11, 2024

Description

Manual backport #8118

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

explicitly the saved object client functions

Signed-off-by: Yulong Ruan <[email protected]>

Changeset file for PR opensearch-project#8118 created/updated
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl ruanyl changed the title [Manual backport] Backport/backport 8118 to 2.x [Manual backport] [Backport 2.x] data source permission client wrapper error of not returning explicitly the saved object client functions Sep 11, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl ruanyl added multiple datasource multiple datasource project v2.17.0 labels Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.91%. Comparing base (52bbe21) to head (b5b90cd).
Report is 7 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8127      +/-   ##
==========================================
+ Coverage   63.79%   63.91%   +0.12%     
==========================================
  Files        3737     3737              
  Lines       88677    88682       +5     
  Branches    13778    13780       +2     
==========================================
+ Hits        56571    56683     +112     
+ Misses      31519    31406     -113     
- Partials      587      593       +6     
Flag Coverage Δ
Linux_1 29.96% <ø> (-0.01%) ⬇️
Linux_2 58.91% <ø> (ø)
Linux_3 40.28% <ø> (+0.19%) ⬆️
Linux_4 31.31% <ø> (ø)
Windows_1 29.98% <ø> (-0.01%) ⬇️
Windows_2 58.86% <ø> (ø)
Windows_3 40.28% <ø> (+0.19%) ⬆️
Windows_4 31.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 2679f53 into opensearch-project:2.x Sep 11, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants