Extended Dataset type config to provide search options like strategy #8113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the strategy Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8113 +/- ##
=======================================
Coverage 63.71% 63.71%
=======================================
Files 3738 3738
Lines 88699 88699
Branches 13793 13793
=======================================
+ Hits 56516 56517 +1
+ Misses 31592 31591 -1
Partials 591 591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
reviewed
Sep 10, 2024
kavilla
reviewed
Sep 10, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]>
kavilla
approved these changes
Sep 10, 2024
ashwin-pc
approved these changes
Sep 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…8113) * added function to provide search strategy; updated interceptors to use the strategy Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b438c2e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Sep 12, 2024
…8113) (#8131) * added function to provide search strategy; updated interceptors to use the strategy * minor refactor * refactored code --------- (cherry picked from commit b438c2e) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
…8113) * added function to provide search strategy; updated interceptors to use the strategy Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b438c2e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Sep 21, 2024
…8113) (#8276) * added function to provide search strategy; updated interceptors to use the strategy * minor refactor * refactored code --------- (cherry picked from commit b438c2e) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Sep 24, 2024
…trategy (opensearch-project#8113) (opensearch-project#8276)" This reverts commit a513a8c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended Dataset type config to provide search options like strategy to shift the strategy provided by language to the dataset itself.
Check List
yarn test:jestyarn test:jest_integration